diff --git a/module/CLI/test/ConfigProviderTest.php b/module/CLI/test/ConfigProviderTest.php index 42a8f504..863b8a1f 100644 --- a/module/CLI/test/ConfigProviderTest.php +++ b/module/CLI/test/ConfigProviderTest.php @@ -4,6 +4,7 @@ declare(strict_types=1); namespace ShlinkioTest\Shlink\CLI; +use Laminas\ServiceManager\AbstractFactory\ConfigAbstractFactory; use PHPUnit\Framework\TestCase; use Shlinkio\Shlink\CLI\ConfigProvider; @@ -21,7 +22,9 @@ class ConfigProviderTest extends TestCase { $config = ($this->configProvider)(); + self::assertCount(3, $config); self::assertArrayHasKey('cli', $config); self::assertArrayHasKey('dependencies', $config); + self::assertArrayHasKey(ConfigAbstractFactory::class, $config); } } diff --git a/module/Core/test/ConfigProviderTest.php b/module/Core/test/ConfigProviderTest.php index 7f4eb8dd..4044446a 100644 --- a/module/Core/test/ConfigProviderTest.php +++ b/module/Core/test/ConfigProviderTest.php @@ -4,6 +4,7 @@ declare(strict_types=1); namespace ShlinkioTest\Shlink\Core; +use Laminas\ServiceManager\AbstractFactory\ConfigAbstractFactory; use PHPUnit\Framework\TestCase; use Shlinkio\Shlink\Core\ConfigProvider; @@ -21,7 +22,11 @@ class ConfigProviderTest extends TestCase { $config = ($this->configProvider)(); + self::assertCount(5, $config); self::assertArrayHasKey('routes', $config); self::assertArrayHasKey('dependencies', $config); + self::assertArrayHasKey('entity_manager', $config); + self::assertArrayHasKey('events', $config); + self::assertArrayHasKey(ConfigAbstractFactory::class, $config); } } diff --git a/module/Core/test/ErrorHandler/NotFoundTemplateHandlerTest.php b/module/Core/test/ErrorHandler/NotFoundTemplateHandlerTest.php index e10954ca..6b9f9989 100644 --- a/module/Core/test/ErrorHandler/NotFoundTemplateHandlerTest.php +++ b/module/Core/test/ErrorHandler/NotFoundTemplateHandlerTest.php @@ -4,29 +4,30 @@ declare(strict_types=1); namespace ShlinkioTest\Shlink\Core\ErrorHandler; +use Closure; use Laminas\Diactoros\Response; use Laminas\Diactoros\ServerRequestFactory; use Mezzio\Router\Route; use Mezzio\Router\RouteResult; -use Mezzio\Template\TemplateRendererInterface; use PHPUnit\Framework\TestCase; -use Prophecy\PhpUnit\ProphecyTrait; -use Prophecy\Prophecy\ObjectProphecy; use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Server\MiddlewareInterface; use Shlinkio\Shlink\Core\ErrorHandler\NotFoundTemplateHandler; class NotFoundTemplateHandlerTest extends TestCase { - use ProphecyTrait; - private NotFoundTemplateHandler $handler; - private ObjectProphecy $renderer; + private Closure $readFile; + private bool $readFileCalled; public function setUp(): void { - $this->renderer = $this->prophesize(TemplateRendererInterface::class); - $this->handler = new NotFoundTemplateHandler($this->renderer->reveal()); + $this->readFileCalled = false; + $this->readFile = function (string $fileName): string { + $this->readFileCalled = true; + return $fileName; + }; + $this->handler = new NotFoundTemplateHandler($this->readFile); } /** @@ -35,13 +36,11 @@ class NotFoundTemplateHandlerTest extends TestCase */ public function properErrorTemplateIsRendered(ServerRequestInterface $request, string $expectedTemplate): void { - $request = $request->withHeader('Accept', 'text/html'); - $render = $this->renderer->render($expectedTemplate)->willReturn(''); - - $resp = $this->handler->handle($request); + $resp = $this->handler->handle($request->withHeader('Accept', 'text/html')); self::assertInstanceOf(Response\HtmlResponse::class, $resp); - $render->shouldHaveBeenCalledOnce(); + self::assertStringContainsString($expectedTemplate, (string) $resp->getBody()); + self::assertTrue($this->readFileCalled); } public function provideTemplates(): iterable diff --git a/module/Rest/test/ConfigProviderTest.php b/module/Rest/test/ConfigProviderTest.php index 69f745ff..462947c9 100644 --- a/module/Rest/test/ConfigProviderTest.php +++ b/module/Rest/test/ConfigProviderTest.php @@ -4,6 +4,7 @@ declare(strict_types=1); namespace ShlinkioTest\Shlink\Rest; +use Laminas\ServiceManager\AbstractFactory\ConfigAbstractFactory; use PHPUnit\Framework\TestCase; use Shlinkio\Shlink\Rest\ConfigProvider; @@ -21,8 +22,12 @@ class ConfigProviderTest extends TestCase { $config = ($this->configProvider)(); + self::assertCount(5, $config); self::assertArrayHasKey('routes', $config); self::assertArrayHasKey('dependencies', $config); + self::assertArrayHasKey('auth', $config); + self::assertArrayHasKey('entity_manager', $config); + self::assertArrayHasKey(ConfigAbstractFactory::class, $config); } /**