From 545da96d15b8aeee81cef76bfd6a0181911c1d23 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Sat, 15 Jan 2022 17:21:36 +0100 Subject: [PATCH] Updated env vars ADR --- ...nv-vars-behavior-to-have-precedence-over-installer-options.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/adr/2022-01-15-update-env-vars-behavior-to-have-precedence-over-installer-options.md b/docs/adr/2022-01-15-update-env-vars-behavior-to-have-precedence-over-installer-options.md index 63231bc1..df11538c 100644 --- a/docs/adr/2022-01-15-update-env-vars-behavior-to-have-precedence-over-installer-options.md +++ b/docs/adr/2022-01-15-update-env-vars-behavior-to-have-precedence-over-installer-options.md @@ -34,6 +34,7 @@ Then Shlink reads this as the first config file, which sets the values as env va * Good because it would not require any change in the installer. * Bad because it requires moving all env var reading logic somewhere else, while having it together with their contextual config is quite convenient. +* Bad because it requires defining a map between the config path from the installer and the env var to set. ### Make the installer generate a config file which also reads env vars