Improved Rest's ConfigProvider test to kill more mutants

This commit is contained in:
Alejandro Celaya 2019-12-01 12:04:31 +01:00
parent fc5904e743
commit 57070ef155
2 changed files with 35 additions and 6 deletions

View File

@ -4,19 +4,26 @@ declare(strict_types=1);
namespace Shlinkio\Shlink\Rest;
use Zend\Config\Factory;
use Zend\Stdlib\Glob;
use function Shlinkio\Shlink\Common\loadConfigFromGlob;
use function sprintf;
class ConfigProvider
{
private const ROUTES_PREFIX = '/rest/v{version:1|2}';
/** @var callable */
private $loadConfig;
public function __construct(?callable $loadConfig = null)
{
$this->loadConfig = $loadConfig ?? function (string $glob) {
return loadConfigFromGlob($glob);
};
}
public function __invoke()
{
/** @var array $config */
$config = Factory::fromFiles(Glob::glob(__DIR__ . '/../config/{,*.}config.php', Glob::GLOB_BRACE));
$config = ($this->loadConfig)(__DIR__ . '/../config/{,*.}config.php');
return $this->applyRoutesPrefix($config);
}

View File

@ -20,9 +20,31 @@ class ConfigProviderTest extends TestCase
/** @test */
public function properConfigIsReturned(): void
{
$config = $this->configProvider->__invoke();
$config = ($this->configProvider)();
$this->assertArrayHasKey('routes', $config);
$this->assertArrayHasKey('dependencies', $config);
}
/** @test */
public function routesAreProperlyPrefixed(): void
{
$configProvider = new ConfigProvider(function () {
return [
'routes' => [
['path' => '/foo'],
['path' => '/bar'],
['path' => '/baz/foo'],
],
];
});
$config = $configProvider();
$this->assertEquals([
['path' => '/rest/v{version:1|2}/foo'],
['path' => '/rest/v{version:1|2}/bar'],
['path' => '/rest/v{version:1|2}/baz/foo'],
], $config['routes']);
}
}