Made test properties to be private instead of protected

This commit is contained in:
Alejandro Celaya
2018-11-20 19:37:22 +01:00
parent 0ae5a53d86
commit 5abd9d1a40
51 changed files with 90 additions and 90 deletions
+4 -4
View File
@@ -12,13 +12,13 @@ class AppOptions extends AbstractOptions
use StringUtilsTrait;
/** @var string */
protected $name = '';
private $name = '';
/** @var string */
protected $version = '1.0';
private $version = '1.0';
/** @var string */
protected $secretKey = '';
private $secretKey = '';
/** @var string|null */
protected $disableTrackParam;
private $disableTrackParam;
/**
* AppOptions constructor.
+3 -3
View File
@@ -19,11 +19,11 @@ use Zend\Diactoros\ServerRequestFactory;
class PixelActionTest extends TestCase
{
/** @var RedirectAction */
protected $action;
private $action;
/** @var ObjectProphecy */
protected $urlShortener;
private $urlShortener;
/** @var ObjectProphecy */
protected $visitTracker;
private $visitTracker;
public function setUp()
{
@@ -24,7 +24,7 @@ use function filesize;
class PreviewActionTest extends TestCase
{
/** @var PreviewAction */
protected $action;
private $action;
/** @var ObjectProphecy */
private $previewGenerator;
/** @var ObjectProphecy */
+2 -2
View File
@@ -21,9 +21,9 @@ use Zend\Expressive\Router\RouterInterface;
class QrCodeActionTest extends TestCase
{
/** @var QrCodeAction */
protected $action;
private $action;
/** @var ObjectProphecy */
protected $urlShortener;
private $urlShortener;
public function setUp()
{
+1 -1
View File
@@ -9,7 +9,7 @@ use Shlinkio\Shlink\Core\ConfigProvider;
class ConfigProviderTest extends TestCase
{
/** @var ConfigProvider */
protected $configProvider;
private $configProvider;
public function setUp()
{
@@ -16,9 +16,9 @@ use Zend\Diactoros\Uri;
class QrCodeCacheMiddlewareTest extends TestCase
{
/** @var QrCodeCacheMiddleware */
protected $middleware;
private $middleware;
/** @var Cache */
protected $cache;
private $cache;
public function setUp()
{
@@ -20,9 +20,9 @@ use function count;
class ShortUrlServiceTest extends TestCase
{
/** @var ShortUrlService */
protected $service;
private $service;
/** @var ObjectProphecy|EntityManagerInterface */
protected $em;
private $em;
public function setUp()
{
@@ -24,13 +24,13 @@ use Zend\Diactoros\Uri;
class UrlShortenerTest extends TestCase
{
/** @var UrlShortener */
protected $urlShortener;
private $urlShortener;
/** @var ObjectProphecy */
protected $em;
private $em;
/** @var ObjectProphecy */
protected $httpClient;
private $httpClient;
/** @var ObjectProphecy */
protected $slugger;
private $slugger;
public function setUp()
{
@@ -21,9 +21,9 @@ use function func_get_args;
class VisitServiceTest extends TestCase
{
/** @var VisitService */
protected $visitService;
private $visitService;
/** @var ObjectProphecy */
protected $em;
private $em;
public function setUp()
{
@@ -17,9 +17,9 @@ use Shlinkio\Shlink\Core\Service\VisitsTracker;
class VisitsTrackerTest extends TestCase
{
/** @var VisitsTracker */
protected $visitsTracker;
private $visitsTracker;
/** @var ObjectProphecy */
protected $em;
private $em;
public function setUp()
{