Merge pull request #503 from acelaya-forks/feature/update-coding-standard

Feature/update coding standard

CHANGELOG.md

@@ -4,6 +4,29 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com), and this project adheres to [Semantic Versioning](https://semver.org).
 
+## [Unreleased]
+
+#### Added
+
+* *Nothing*
+
+#### Changed
+
+* [#458](https://github.com/shlinkio/shlink/issues/458) Updated coding styles to use [shlinkio/php-coding-standard](https://github.com/shlinkio/php-coding-standard) v2.0.0.
+
+#### Deprecated
+
+* *Nothing*
+
+#### Removed
+
+* * *Nothing*
+
+#### Fixed
+
+* *Nothing*
+
+
 ## 1.19.0 - 2019-10-05
 
 #### Added

composer.json

@@ -64,7 +64,7 @@
         "phpunit/phpcov": "^6.0",
         "phpunit/phpunit": "^8.3",
         "roave/security-advisories": "dev-master",
-        "shlinkio/php-coding-standard": "~1.2.2",
+        "shlinkio/php-coding-standard": "~2.0.0",
         "shlinkio/shlink-test-utils": "^1.0",
         "symfony/dotenv": "^4.3",
         "symfony/var-dumper": "^4.3",

config/autoload/app_options.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use function Shlinkio\Shlink\Common\env;

config/autoload/client-detection.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

config/autoload/common.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Zend\ConfigAggregator\ConfigAggregator;

config/autoload/delete_short_urls.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

config/autoload/dependencies.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Zend\Expressive;

config/autoload/entity-manager.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Common;

config/autoload/geolite2.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

config/autoload/installer.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Shlinkio\Shlink\Installer\Config\Plugin;

config/autoload/locks.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Shlinkio\Shlink\Common\Cache\RedisFactory;

config/autoload/logger.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

config/autoload/middleware-pipeline.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

config/autoload/preview-generation.global.php

@@ -1,7 +1,8 @@
 <?php
+
 declare(strict_types=1);
 
-/** @deprecated */
+/* @deprecated */
 return [
 
     'preview_generation' => [

config/autoload/router.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Zend\Expressive\Router\FastRouteRouter;

config/autoload/swoole.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

config/autoload/templates.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

config/autoload/url-shortener.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Shlinkio\Shlink\Core\Options\UrlShortenerOptions;

config/autoload/wkhtmltopdf.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

config/cli-config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Doctrine\ORM\EntityManager;
@@ -6,8 +7,10 @@ use Doctrine\ORM\Tools\Console\ConsoleRunner;
 use Psr\Container\ContainerInterface;
 use Zend\ServiceManager\ServiceManager;
 
-/** @var ContainerInterface|ServiceManager $container */
-$container = include __DIR__ . '/container.php';
-$em = $container->get(EntityManager::class);
+return (function () {
+    /** @var ContainerInterface|ServiceManager $container */
+    $container = include __DIR__ . '/container.php';
+    $em = $container->get(EntityManager::class);
 
-return ConsoleRunner::createHelperSet($em);
+    return ConsoleRunner::createHelperSet($em);
+})();

config/config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

config/container.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 use Symfony\Component\Dotenv\Dotenv;

config/test/bootstrap_api_tests.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\TestUtils;

config/test/bootstrap_db_tests.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\TestUtils;

config/test/test_config.global.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

data/migrations/Version20160819142757.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20160820191203.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20171021093246.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20171022064541.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20180801183328.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20180913205455.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20180915110857.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20181020060559.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20181020065148.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20181110175521.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20190824075137.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20190930165521.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

data/migrations/Version20191001201532.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkMigrations;

docker/config/shlink_in_docker.local.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink;

module/CLI/config/cli.config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI;

module/CLI/config/dependencies.config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI;

module/CLI/src/Command/Api/DisableKeyCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Api;

module/CLI/src/Command/Api/GenerateKeyCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Api;

module/CLI/src/Command/Api/ListKeysCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Api;

module/CLI/src/Command/Config/GenerateCharsetCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Config;

module/CLI/src/Command/Config/GenerateSecretCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Config;

module/CLI/src/Command/Db/AbstractDatabaseCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Db;

module/CLI/src/Command/Db/CreateDatabaseCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Db;

module/CLI/src/Command/Db/MigrateDatabaseCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Db;

module/CLI/src/Command/ShortUrl/DeleteShortUrlCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/ShortUrl/GeneratePreviewCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/ShortUrl/GenerateShortUrlCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/ShortUrl/GetVisitsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/ShortUrl/ResolveUrlCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\ShortUrl;

module/CLI/src/Command/Tag/CreateTagCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Tag;

module/CLI/src/Command/Tag/DeleteTagsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Tag;

module/CLI/src/Command/Tag/ListTagsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Tag;

module/CLI/src/Command/Tag/RenameTagCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Tag;

module/CLI/src/Command/Util/AbstractLockedCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Util;

module/CLI/src/Command/Util/LockedCommandConfig.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Util;

module/CLI/src/Command/Visit/LocateVisitsCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Visit;

module/CLI/src/Command/Visit/UpdateDbCommand.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Command\Visit;

module/CLI/src/ConfigProvider.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI;

module/CLI/src/Exception/ExceptionInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Exception;

module/CLI/src/Exception/GeolocationDbUpdateFailedException.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Exception;

module/CLI/src/Factory/ApplicationFactory.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Factory;

module/CLI/src/Util/ExitCodes.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Util;

module/CLI/src/Util/GeolocationDbUpdater.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Util;

module/CLI/src/Util/GeolocationDbUpdaterInterface.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Util;

module/CLI/src/Util/ShlinkTable.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\CLI\Util;

module/CLI/test/Command/Api/DisableKeyCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Api;

module/CLI/test/Command/Api/GenerateKeyCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Api;

module/CLI/test/Command/Api/ListKeysCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Api;

module/CLI/test/Command/Config/GenerateCharsetCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Config;

module/CLI/test/Command/Db/CreateDatabaseCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Db;

module/CLI/test/Command/Db/MigrateDatabaseCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Db;

module/CLI/test/Command/ShortUrl/DeleteShortUrlCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/ShortUrl/GeneratePreviewCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/ShortUrl/GenerateShortUrlCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/ShortUrl/GetVisitsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/ShortUrl/ListShortUrlsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/ShortUrl/ResolveUrlCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;

module/CLI/test/Command/Tag/CreateTagCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Tag;

module/CLI/test/Command/Tag/DeleteTagsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Tag;

module/CLI/test/Command/Tag/ListTagsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Tag;

module/CLI/test/Command/Tag/RenameTagCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Tag;

module/CLI/test/Command/Visit/LocateVisitsCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Visit;

module/CLI/test/Command/Visit/UpdateDbCommandTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Command\Visit;

module/CLI/test/ConfigProviderTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI;

module/CLI/test/Exception/GeolocationDbUpdateFailedExceptionTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Exception;

module/CLI/test/Factory/ApplicationFactoryTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Factory;

module/CLI/test/Util/GeolocationDbUpdaterTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Util;

module/CLI/test/Util/ShlinkTableTest.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace ShlinkioTest\Shlink\CLI\Util;

module/Core/config/app_options.config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 return [

module/Core/config/dependencies.config.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core;

module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.Domain.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core;
@@ -7,7 +8,7 @@ use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
 use Doctrine\ORM\Mapping\ClassMetadata; // @codingStandardsIgnoreLine
 
-/** @var $metadata ClassMetadata */
+/** @var $metadata ClassMetadata */ // @codingStandardsIgnoreLine
 $builder = new ClassMetadataBuilder($metadata);
 
 $builder->setTable('domains');

module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.ShortUrl.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core;
@@ -8,7 +9,7 @@ use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
 use Doctrine\ORM\Mapping\ClassMetadata; // @codingStandardsIgnoreLine
 use Shlinkio\Shlink\Common\Doctrine\Type\ChronosDateTimeType;
 
-/** @var $metadata ClassMetadata */
+/** @var $metadata ClassMetadata */ // @codingStandardsIgnoreLine
 $builder = new ClassMetadataBuilder($metadata);
 
 $builder->setTable('short_urls')

module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.Tag.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core;
@@ -7,7 +8,7 @@ use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
 use Doctrine\ORM\Mapping\ClassMetadata; // @codingStandardsIgnoreLine
 
-/** @var $metadata ClassMetadata */
+/** @var $metadata ClassMetadata */ // @codingStandardsIgnoreLine
 $builder = new ClassMetadataBuilder($metadata);
 
 $builder->setTable('tags')

module/Core/config/entities-mappings/Shlinkio.Shlink.Core.Entity.Visit.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Shlinkio\Shlink\Core;
@@ -9,7 +10,7 @@ use Doctrine\ORM\Mapping\ClassMetadata; // @codingStandardsIgnoreLine
 use Shlinkio\Shlink\Common\Doctrine\Type\ChronosDateTimeType;
 use Shlinkio\Shlink\Core\Model\Visitor;
 
-/** @var $metadata ClassMetadata */
+/** @var $metadata ClassMetadata */ // @codingStandardsIgnoreLine
 $builder = new ClassMetadataBuilder($metadata);
 
 $builder->setTable('visits')