OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-11-22 08:56:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

Migrated DoctrineBatchHelperTest to use PHPUnit mocks

Browse Source
This commit is contained in:
Alejandro Celaya 2022-10-23 20:32:13 +02:00
parent 3b25fb27fe
commit 796543d194
1 changed files with 14 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
module/Core/test/Util/DoctrineBatchHelperTest.php
View File

@ -5,23 +5,20 @@ declare(strict_types=1);
namespace ShlinkioTest\Shlink\Core\Util; namespace ShlinkioTest\Shlink\Core\Util;
use Doctrine\ORM\EntityManagerInterface; use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use RuntimeException; use RuntimeException;
use Shlinkio\Shlink\Core\Util\DoctrineBatchHelper; use Shlinkio\Shlink\Core\Util\DoctrineBatchHelper;
class DoctrineBatchHelperTest extends TestCase class DoctrineBatchHelperTest extends TestCase
{ {
use ProphecyTrait;
private DoctrineBatchHelper $helper; private DoctrineBatchHelper $helper;
private ObjectProphecy $em; private MockObject $em;
protected function setUp(): void protected function setUp(): void
{ {
$this->em = $this->prophesize(EntityManagerInterface::class); $this->em = $this->createMock(EntityManagerInterface::class);
$this->helper = new DoctrineBatchHelper($this->em->reveal()); $this->helper = new DoctrineBatchHelper($this->em);
} }
/** /**
@ -33,17 +30,17 @@ class DoctrineBatchHelperTest extends TestCase
int $batchSize, int $batchSize,
int $expectedCalls, int $expectedCalls,
): void { ): void {
$this->em->expects($this->once())->method('beginTransaction');
$this->em->expects($this->once())->method('commit');
$this->em->expects($this->never())->method('rollback');
$this->em->expects($this->exactly($expectedCalls))->method('flush');
$this->em->expects($this->exactly($expectedCalls))->method('clear');
$wrappedIterable = $this->helper->wrapIterable($iterable, $batchSize); $wrappedIterable = $this->helper->wrapIterable($iterable, $batchSize);
foreach ($wrappedIterable as $item) { foreach ($wrappedIterable as $item) {
// Iterable needs to be iterated for the logic to be invoked // Iterable needs to be iterated for the logic to be invoked
} }
$this->em->beginTransaction()->shouldHaveBeenCalledOnce();
$this->em->commit()->shouldHaveBeenCalledOnce();
$this->em->rollback()->shouldNotHaveBeenCalled();
$this->em->flush()->shouldHaveBeenCalledTimes($expectedCalls);
$this->em->clear()->shouldHaveBeenCalledTimes($expectedCalls);
} }
public function provideIterables(): iterable public function provideIterables(): iterable
@ -56,15 +53,14 @@ class DoctrineBatchHelperTest extends TestCase
/** @test */ /** @test */
public function transactionIsRolledBackWhenAnErrorOccurs(): void public function transactionIsRolledBackWhenAnErrorOccurs(): void
{ {
$flush = $this->em->flush()->willThrow(RuntimeException::class); $this->em->expects($this->once())->method('flush')->willThrowException(new RuntimeException());
$this->em->expects($this->once())->method('beginTransaction');
$this->em->expects($this->never())->method('commit');
$this->em->expects($this->once())->method('rollback');
$wrappedIterable = $this->helper->wrapIterable([1, 2, 3], 1); $wrappedIterable = $this->helper->wrapIterable([1, 2, 3], 1);
self::expectException(RuntimeException::class); self::expectException(RuntimeException::class);
$flush->shouldBeCalledOnce();
$this->em->beginTransaction()->shouldBeCalledOnce();
$this->em->commit()->shouldNotBeCalled();
$this->em->rollback()->shouldBeCalledOnce();
foreach ($wrappedIterable as $item) { foreach ($wrappedIterable as $item) {
// Iterable needs to be iterated for the logic to be invoked // Iterable needs to be iterated for the logic to be invoked