Improved error management on install command

module/CLI/src/Command/Install/InstallCommand.php

@@ -94,14 +94,33 @@ class InstallCommand extends Command
         $output->writeln(['<info>Custom configuration properly generated!</info>', '']);
 
         // Generate database
-        $output->write('Initializing database...');
+        $output->writeln('Initializing database...');
-        $this->processHelper->run($output, 'php vendor/bin/doctrine.php orm:schema-tool:create');
+        $process = $this->processHelper->run($output, 'php vendor/bin/doctrine.php orm:schema-tool:create');
-        $output->writeln(' <info>Success!</info>');
+        if ($process->isSuccessful()) {
+            $output->writeln('    <info>Success!</info>');
+        } else {
+            if ($output->isVerbose()) {
+                return;
+            }
+            $output->writeln(
+                '    <error>Error generating database.</error>  Run this command with -vvv to see specific error info.'
+            );
+            return;
+        }
 
         // Generate proxies
-        $output->write('Generating proxies...');
+        $output->writeln('Generating proxies...');
-        $this->processHelper->run($output, 'php vendor/bin/doctrine.php orm:generate-proxies');
+        $process = $this->processHelper->run($output, 'php vendor/bin/doctrine.php orm:generate-proxies');
-        $output->writeln(' <info>Success!</info>');
+        if ($process->isSuccessful()) {
+            $output->writeln('    <info>Success!</info>');
+        } else {
+            if ($output->isVerbose()) {
+                return;
+            }
+            $output->writeln(
+                '    <error>Error generating proxies.</error>  Run this command with -vvv to see specific error info.'
+            );
+        }
     }
 
     protected function askDatabase()

module/CLI/test/Command/Install/InstallCommandTest.php

@@ -8,6 +8,7 @@ use Shlinkio\Shlink\CLI\Command\Install\InstallCommand;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper\ProcessHelper;
 use Symfony\Component\Console\Tester\CommandTester;
+use Symfony\Component\Process\Process;
 use Zend\Config\Writer\WriterInterface;
 
 class InstallCommandTest extends TestCase
@@ -23,10 +24,12 @@ class InstallCommandTest extends TestCase
 
     public function setUp()
     {
+        $processMock = $this->prophesize(Process::class);
+        $processMock->isSuccessful()->willReturn(true);
         $processHelper = $this->prophesize(ProcessHelper::class);
         $processHelper->getName()->willReturn('process');
         $processHelper->setHelperSet(Argument::any())->willReturn(null);
-        $processHelper->run(Argument::cetera())->willReturn(null);
+        $processHelper->run(Argument::cetera())->willReturn($processMock->reveal());
 
         $app = new Application();
         $helperSet = $app->getHelperSet();

phpcs.xml

@@ -20,4 +20,5 @@
     <file>module</file>
     <file>config</file>
     <file>public/index.php</file>
+    <exclude-pattern>config/params/*</exclude-pattern>
 </ruleset>