OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add tests covering country code validation

Browse Source
This commit is contained in:
Alejandro Celaya 2024-11-14 09:40:10 +01:00
parent fd34332e69
commit 7ddb3e7a70
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
module/Core/test/RedirectRule/Model/RedirectRulesDataTest.php
View File

@ -63,6 +63,18 @@ class RedirectRulesDataTest extends TestCase
], ],
], ],
]]])] ]]])]
#[TestWith([['redirectRules' => [
[
'longUrl' => 'https://example.com',
'conditions' => [
[
'type' => 'geolocation-country-code',
'matchKey' => null,
'matchValue' => 'not an country code',
],
],
],
]]])]
public function throwsWhenProvidedDataIsInvalid(array $invalidData): void public function throwsWhenProvidedDataIsInvalid(array $invalidData): void
{ {
$this->expectException(ValidationException::class); $this->expectException(ValidationException::class);
@ -118,6 +130,18 @@ class RedirectRulesDataTest extends TestCase
], ],
], ],
]]], 'in-between IP wildcard pattern')] ]]], 'in-between IP wildcard pattern')]
#[TestWith([['redirectRules' => [
[
'longUrl' => 'https://example.com',
'conditions' => [
[
'type' => 'geolocation-country-code',
'matchKey' => null,
'matchValue' => 'US',
],
],
],
]]], 'country code')]
public function allowsValidDataToBeSet(array $validData): void public function allowsValidDataToBeSet(array $validData): void
{ {
$result = RedirectRulesData::fromRawData($validData); $result = RedirectRulesData::fromRawData($validData);

14
module/Rest/test-api/Action/SetRedirectRulesTest.php
View File

@ -96,6 +96,20 @@ class SetRedirectRulesTest extends ApiTestCase
], ],
], ],
]], 'invalid IP address')] ]], 'invalid IP address')]
#[TestWith([[
'redirectRules' => [
[
'longUrl' => 'https://example.com',
'conditions' => [
[
'type' => 'geolocation-country-code',
'matchKey' => null,
'matchValue' => 'not a country code',
],
],
],
],
]], 'invalid country code')]
public function errorIsReturnedWhenInvalidDataIsProvided(array $bodyPayload): void public function errorIsReturnedWhenInvalidDataIsProvided(array $bodyPayload): void
{ {
$response = $this->callApiWithKey(self::METHOD_POST, '/short-urls/abc123/redirect-rules', [ $response = $this->callApiWithKey(self::METHOD_POST, '/short-urls/abc123/redirect-rules', [