Merge pull request #313 from acelaya/feature/favicon

Feature/favicon
This commit is contained in:
Alejandro Celaya 2018-12-07 09:45:55 +01:00 committed by GitHub
commit 8a23c90e46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 36 additions and 34 deletions

View File

@ -24,7 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
#### Fixed #### Fixed
* *Nothing* * [#309](https://github.com/shlinkio/shlink/issues/309) Added missing favicon to prevent 404 errors logged when an error page is loaded in a browser.
## 1.15.0 - 2018-12-02 ## 1.15.0 - 2018-12-02

View File

@ -9,9 +9,6 @@ return [
'swoole-http-server' => [ 'swoole-http-server' => [
'host' => '0.0.0.0', 'host' => '0.0.0.0',
'process-name' => 'shlink', 'process-name' => 'shlink',
'static-files' => [
'enable' => false,
],
], ],
], ],

View File

@ -20,5 +20,6 @@ class TranslatorExtension implements ExtensionInterface
public function register(Engine $engine): void public function register(Engine $engine): void
{ {
$engine->registerFunction('translate', [$this->translator, 'translate']); $engine->registerFunction('translate', [$this->translator, 'translate']);
$engine->registerFunction('locale', [$this->translator, 'getLocale']);
} }
} }

View File

@ -25,11 +25,14 @@ class TranslatorExtensionTest extends TestCase
public function properFunctionsAreReturned() public function properFunctionsAreReturned()
{ {
$engine = $this->prophesize(Engine::class); $engine = $this->prophesize(Engine::class);
$registerFunction = $engine->registerFunction('translate', Argument::type('callable'))->will(function () { $registerTranslate = $engine->registerFunction('translate', Argument::type('callable'))->will(function () {
});
$registerLocale = $engine->registerFunction('locale', Argument::type('array'))->will(function () {
}); });
$this->extension->register($engine->reveal()); $this->extension->register($engine->reveal());
$registerFunction->shouldHaveBeenCalledOnce(); $registerTranslate->shouldHaveBeenCalledOnce();
$registerLocale->shouldHaveBeenCalledOnce();
} }
} }

View File

@ -1,11 +1,12 @@
<!DOCTYPE html> <!DOCTYPE html>
<html> <html lang="<?= $this->locale() ?>">
<head> <head>
<title><?= $this->section('title', '') ?> | URL shortener</title> <title><?= $this->section('title', '') ?> | URL shortener</title>
<meta charset="utf-8" /> <meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge" /> <meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1" /> <meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css" /> <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css">
<link rel="shortcut icon" href="/favicon.ico">
<style> <style>
body {padding-top: 60px;} body {padding-top: 60px;}
.app {display: flex; min-height: 100vh; flex-direction: column;} .app {display: flex; min-height: 100vh; flex-direction: column;}
@ -23,7 +24,7 @@
<footer class="app-footer"> <footer class="app-footer">
<div class="container"> <div class="container">
<hr /> <hr>
<p>&copy; <?= date('Y') ?> <a href="https://shlink.io">Shlink</a></p> <p>&copy; <?= date('Y') ?> <a href="https://shlink.io">Shlink</a></p>
</div> </div>
</footer> </footer>

BIN
public/favicon.ico Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 17 KiB