From 4745a3754996469ca7f69b5d64174fb3868fb526 Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Fri, 16 Nov 2018 16:44:48 +0100 Subject: [PATCH] Used a lower level on phpstan to avoid errors produced by Symfony 4.1.5 new phpdocs --- composer.json | 8 ++++---- module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php | 2 +- phpstan.neon | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/composer.json b/composer.json index 6c49c9e4..87d7cabc 100644 --- a/composer.json +++ b/composer.json @@ -30,9 +30,9 @@ "mikehaertl/phpwkhtmltopdf": "^2.2", "monolog/monolog": "^1.21", "roave/security-advisories": "dev-master", - "symfony/console": "^4.0 <4.1.5", - "symfony/filesystem": "^4.0", - "symfony/process": "^4.0", + "symfony/console": "^4.1", + "symfony/filesystem": "^4.1", + "symfony/process": "^4.1", "theorchard/monolog-cascade": "^0.4", "zendframework/zend-config": "^3.0", "zendframework/zend-config-aggregator": "^1.0", @@ -102,7 +102,7 @@ "cs": "phpcs", "cs:fix": "phpcbf", - "stan": "phpstan analyse module/*/src/ --level=6 -c phpstan.neon", + "stan": "phpstan analyse module/*/src/ --level=5 -c phpstan.neon", "test": [ "@test:unit", diff --git a/module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php b/module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php index 516da14b..0ca2a96c 100644 --- a/module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php +++ b/module/CLI/src/Command/ShortUrl/ListShortUrlsCommand.php @@ -64,7 +64,7 @@ class ListShortUrlsCommand extends Command $this->translator->translate('The first page to list (%s items per page)'), PaginableRepositoryAdapter::ITEMS_PER_PAGE ), - 1 + '1' ) ->addOption( 'searchTerm', diff --git a/phpstan.neon b/phpstan.neon index c67d210b..96f5d0c3 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -1,6 +1,4 @@ parameters: - excludes_analyse: - - module/Common/src/Template/Extension/TranslatorExtension.php - - module/Rest/src/Util/RestUtils.php ignoreErrors: + - '#League\\Plates\\callback#' - '#is not subtype of Throwable#'