OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-01-03 12:46:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1570 from acelaya-forks/feature/phpunit-mocks

Browse Source 
Migrated to PHPUnit mocks in RobotsActionTest
This commit is contained in:
Alejandro Celaya 2022-10-12 18:56:24 +02:00 committed by GitHub
commit 9049a205b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/actions/ci-setup/action.yml vendored
View File

@ -41,7 +41,7 @@ runs:
extensions: ${{ inputs.php-extensions }} extensions: ${{ inputs.php-extensions }}
coverage: pcov coverage: pcov
ini-values: pcov.directory=module ini-values: pcov.directory=module
- run: echo "::set-output name=composerArgs::${{ inputs.php-version == '8.2' && '--ignore-platform-req=php' || '' }}" - run: echo "::set-output name=composerArgs::${{ inputs.php-version == '8.2' && '--ignore-platform-req=php+' || '' }}"
id: composer_args id: composer_args
shell: bash shell: bash
- name: Install dependencies - name: Install dependencies

2
.github/workflows/ci.yml vendored
View File

@ -52,7 +52,7 @@ jobs:
with: with:
php-version: ${{ matrix.php-version }} php-version: ${{ matrix.php-version }}
tools: composer tools: composer
- run: echo "::set-output name=composerArgs::${{ matrix.php-version == '8.2' && '--ignore-platform-req=php' || '' }}" - run: echo "::set-output name=composerArgs::${{ matrix.php-version == '8.2' && '--ignore-platform-req=php+' || '' }}"
id: composer_args id: composer_args
shell: bash shell: bash
- run: composer install --no-interaction --prefer-dist ${{ steps.composer_args.outputs.composerArgs }} - run: composer install --no-interaction --prefer-dist ${{ steps.composer_args.outputs.composerArgs }}

2
indocker
View File

@ -1,7 +1,7 @@
#!/usr/bin/env bash #!/usr/bin/env bash
# Run docker containers if they are not up yet # Run docker containers if they are not up yet
if ! [[ $(docker ps | grep shlink) ]]; then if ! [[ $(docker ps | grep shlink_swoole) ]]; then
docker-compose up -d docker-compose up -d
fi fi

2
module/Core/src/Action/RobotsAction.php
View File

@ -17,7 +17,7 @@ use const PHP_EOL;
class RobotsAction implements RequestHandlerInterface, StatusCodeInterface class RobotsAction implements RequestHandlerInterface, StatusCodeInterface
{ {
public function __construct(private CrawlingHelperInterface $crawlingHelper) public function __construct(private readonly CrawlingHelperInterface $crawlingHelper)
{ {
} }

2
module/Core/src/Crawling/CrawlingHelperInterface.php
View File

@ -7,7 +7,7 @@ namespace Shlinkio\Shlink\Core\Crawling;
interface CrawlingHelperInterface interface CrawlingHelperInterface
{ {
/** /**
* @return string[]|iterable * @return iterable<string>
*/ */
public function listCrawlableShortCodes(): iterable; public function listCrawlableShortCodes(): iterable;
} }

17
module/Core/test/Action/RobotsActionTest.php
View File

@ -5,23 +5,20 @@ declare(strict_types=1);
namespace ShlinkioTest\Shlink\Core\Action; namespace ShlinkioTest\Shlink\Core\Action;
use Laminas\Diactoros\ServerRequestFactory; use Laminas\Diactoros\ServerRequestFactory;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Core\Action\RobotsAction; use Shlinkio\Shlink\Core\Action\RobotsAction;
use Shlinkio\Shlink\Core\Crawling\CrawlingHelperInterface; use Shlinkio\Shlink\Core\Crawling\CrawlingHelperInterface;
class RobotsActionTest extends TestCase class RobotsActionTest extends TestCase
{ {
use ProphecyTrait;
private RobotsAction $action; private RobotsAction $action;
private ObjectProphecy $helper; private MockObject $helper;
protected function setUp(): void protected function setUp(): void
{ {
$this->helper = $this->prophesize(CrawlingHelperInterface::class); $this->helper = $this->createMock(CrawlingHelperInterface::class);
$this->action = new RobotsAction($this->helper->reveal()); $this->action = new RobotsAction($this->helper);
} }
/** /**
@ -30,14 +27,16 @@ class RobotsActionTest extends TestCase
*/ */
public function buildsRobotsLinesFromCrawlableShortCodes(array $shortCodes, string $expected): void public function buildsRobotsLinesFromCrawlableShortCodes(array $shortCodes, string $expected): void
{ {
$getShortCodes = $this->helper->listCrawlableShortCodes()->willReturn($shortCodes); $this->helper
->expects($this->once())
->method('listCrawlableShortCodes')
->willReturn($shortCodes);
$response = $this->action->handle(ServerRequestFactory::fromGlobals()); $response = $this->action->handle(ServerRequestFactory::fromGlobals());
self::assertEquals(200, $response->getStatusCode()); self::assertEquals(200, $response->getStatusCode());
self::assertEquals($expected, $response->getBody()->__toString()); self::assertEquals($expected, $response->getBody()->__toString());
self::assertEquals('text/plain', $response->getHeaderLine('Content-Type')); self::assertEquals('text/plain', $response->getHeaderLine('Content-Type'));
$getShortCodes->shouldHaveBeenCalledOnce();
} }
public function provideShortCodes(): iterable public function provideShortCodes(): iterable