OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-12-27 01:11:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Enforced short URLs length to be 4 at least

Browse Source
This commit is contained in:
Alejandro Celaya 2020-02-18 18:57:24 +01:00
parent 13555366e3
commit 9372d1739a
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
module/Core/src/Validation/ShortUrlMetaInputFilter.php
View File

@ -43,7 +43,7 @@ class ShortUrlMetaInputFilter extends InputFilter
$this->add($customSlug);
$this->add($this->createPositiveNumberInput(self::MAX_VISITS));
$this->add($this->createPositiveNumberInput(self::SHORT_CODE_LENGTH));
$this->add($this->createPositiveNumberInput(self::SHORT_CODE_LENGTH, 4));
$this->add($this->createBooleanInput(self::FIND_IF_EXISTS, false));
@ -52,11 +52,11 @@ class ShortUrlMetaInputFilter extends InputFilter
$this->add($domain);
}
private function createPositiveNumberInput(string $name): Input
private function createPositiveNumberInput(string $name, int $min = 1): Input
{
$input = $this->createInput($name, false);
$input->getValidatorChain()->attach(new Validator\Digits())
->attach(new Validator\GreaterThan(['min' => 1, 'inclusive' => true]));
->attach(new Validator\GreaterThan(['min' => $min, 'inclusive' => true]));
return $input;
}

2
module/Core/test/Entity/ShortUrlTest.php
View File

@ -72,6 +72,6 @@ class ShortUrlTest extends TestCase
public function provideLengths(): iterable
{
yield [null, DEFAULT_SHORT_CODES_LENGTH];
yield from map(range(1, 10), fn (int $value) => [$value, $value]);
yield from map(range(4, 10), fn (int $value) => [$value, $value]);
}
}

3
module/Core/test/Model/ShortUrlMetaTest.php
View File

@ -44,6 +44,9 @@ class ShortUrlMetaTest extends TestCase
ShortUrlMetaInputFilter::VALID_UNTIL => 500,
ShortUrlMetaInputFilter::DOMAIN => 4,
]];
yield [[
ShortUrlMetaInputFilter::SHORT_CODE_LENGTH => 3,
]];
}
/** @test */