OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-12-22 23:23:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

Migrated QrActionTest to use PHPUnit mocks

Browse Source
This commit is contained in:
Alejandro Celaya 2022-10-21 18:39:22 +02:00
parent 843754b7e7
commit cd4b632d75
1 changed files with 31 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
module/Core/test/Action/QrCodeActionTest.php
View File

@ -7,10 +7,8 @@ namespace ShlinkioTest\Shlink\Core\Action;
use Laminas\Diactoros\Response; use Laminas\Diactoros\Response;
use Laminas\Diactoros\ServerRequest; use Laminas\Diactoros\ServerRequest;
use Laminas\Diactoros\ServerRequestFactory; use Laminas\Diactoros\ServerRequestFactory;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface; use Psr\Http\Server\RequestHandlerInterface;
use Psr\Log\NullLogger; use Psr\Log\NullLogger;
@ -29,50 +27,43 @@ use function imagecreatefromstring;
class QrCodeActionTest extends TestCase class QrCodeActionTest extends TestCase
{ {
use ProphecyTrait;
private const WHITE = 0xFFFFFF; private const WHITE = 0xFFFFFF;
private const BLACK = 0x0; private const BLACK = 0x0;
private ObjectProphecy $urlResolver; private MockObject $urlResolver;
protected function setUp(): void protected function setUp(): void
{ {
$this->urlResolver = $this->prophesize(ShortUrlResolverInterface::class); $this->urlResolver = $this->createMock(ShortUrlResolverInterface::class);
} }
/** @test */ /** @test */
public function aNotFoundShortCodeWillDelegateIntoNextMiddleware(): void public function aNotFoundShortCodeWillDelegateIntoNextMiddleware(): void
{ {
$shortCode = 'abc123'; $shortCode = 'abc123';
$this->urlResolver->resolveEnabledShortUrl(ShortUrlIdentifier::fromShortCodeAndDomain($shortCode, '')) $this->urlResolver->expects($this->once())->method('resolveEnabledShortUrl')->with(
->willThrow(ShortUrlNotFoundException::class) $this->equalTo(ShortUrlIdentifier::fromShortCodeAndDomain($shortCode, ''))
->shouldBeCalledOnce(); )->willThrowException(ShortUrlNotFoundException::fromNotFound(ShortUrlIdentifier::fromShortCodeAndDomain('')));
$delegate = $this->prophesize(RequestHandlerInterface::class); $delegate = $this->createMock(RequestHandlerInterface::class);
$process = $delegate->handle(Argument::any())->willReturn(new Response()); $delegate->expects($this->once())->method('handle')->withAnyParameters()->willReturn(new Response());
$this->action()->process((new ServerRequest())->withAttribute('shortCode', $shortCode), $delegate->reveal()); $this->action()->process((new ServerRequest())->withAttribute('shortCode', $shortCode), $delegate);
$process->shouldHaveBeenCalledOnce();
} }
/** @test */ /** @test */
public function aCorrectRequestReturnsTheQrCodeResponse(): void public function aCorrectRequestReturnsTheQrCodeResponse(): void
{ {
$shortCode = 'abc123'; $shortCode = 'abc123';
$this->urlResolver->resolveEnabledShortUrl(ShortUrlIdentifier::fromShortCodeAndDomain($shortCode, '')) $this->urlResolver->expects($this->once())->method('resolveEnabledShortUrl')->with(
->willReturn(ShortUrl::createEmpty()) $this->equalTo(ShortUrlIdentifier::fromShortCodeAndDomain($shortCode, '')),
->shouldBeCalledOnce(); )->willReturn(ShortUrl::createEmpty());
$delegate = $this->prophesize(RequestHandlerInterface::class); $delegate = $this->createMock(RequestHandlerInterface::class);
$delegate->expects($this->never())->method('handle');
$resp = $this->action()->process( $resp = $this->action()->process((new ServerRequest())->withAttribute('shortCode', $shortCode), $delegate);
(new ServerRequest())->withAttribute('shortCode', $shortCode),
$delegate->reveal(),
);
self::assertInstanceOf(QrCodeResponse::class, $resp); self::assertInstanceOf(QrCodeResponse::class, $resp);
self::assertEquals(200, $resp->getStatusCode()); self::assertEquals(200, $resp->getStatusCode());
$delegate->handle(Argument::any())->shouldHaveBeenCalledTimes(0);
} }
/** /**
@ -85,13 +76,13 @@ class QrCodeActionTest extends TestCase
string $expectedContentType, string $expectedContentType,
): void { ): void {
$code = 'abc123'; $code = 'abc123';
$this->urlResolver->resolveEnabledShortUrl(ShortUrlIdentifier::fromShortCodeAndDomain($code, ''))->willReturn( $this->urlResolver->method('resolveEnabledShortUrl')->with(
ShortUrl::createEmpty(), $this->equalTo(ShortUrlIdentifier::fromShortCodeAndDomain($code, '')),
); )->willReturn(ShortUrl::createEmpty());
$delegate = $this->prophesize(RequestHandlerInterface::class); $delegate = $this->createMock(RequestHandlerInterface::class);
$req = (new ServerRequest())->withAttribute('shortCode', $code)->withQueryParams($query); $req = (new ServerRequest())->withAttribute('shortCode', $code)->withQueryParams($query);
$resp = $this->action(new QrCodeOptions(format: $defaultFormat))->process($req, $delegate->reveal()); $resp = $this->action(new QrCodeOptions(format: $defaultFormat))->process($req, $delegate);
self::assertEquals($expectedContentType, $resp->getHeaderLine('Content-Type')); self::assertEquals($expectedContentType, $resp->getHeaderLine('Content-Type'));
} }
@ -118,12 +109,12 @@ class QrCodeActionTest extends TestCase
int $expectedSize, int $expectedSize,
): void { ): void {
$code = 'abc123'; $code = 'abc123';
$this->urlResolver->resolveEnabledShortUrl(ShortUrlIdentifier::fromShortCodeAndDomain($code, ''))->willReturn( $this->urlResolver->method('resolveEnabledShortUrl')->with(
ShortUrl::createEmpty(), $this->equalTo(ShortUrlIdentifier::fromShortCodeAndDomain($code, '')),
); )->willReturn(ShortUrl::createEmpty());
$delegate = $this->prophesize(RequestHandlerInterface::class); $delegate = $this->createMock(RequestHandlerInterface::class);
$resp = $this->action($defaultOptions)->process($req->withAttribute('shortCode', $code), $delegate->reveal()); $resp = $this->action($defaultOptions)->process($req->withAttribute('shortCode', $code), $delegate);
[$size] = getimagesizefromstring($resp->getBody()->__toString()); [$size] = getimagesizefromstring($resp->getBody()->__toString());
self::assertEquals($expectedSize, $size); self::assertEquals($expectedSize, $size);
@ -209,12 +200,12 @@ class QrCodeActionTest extends TestCase
->withQueryParams(['size' => 250, 'roundBlockSize' => $roundBlockSize]) ->withQueryParams(['size' => 250, 'roundBlockSize' => $roundBlockSize])
->withAttribute('shortCode', $code); ->withAttribute('shortCode', $code);
$this->urlResolver->resolveEnabledShortUrl(ShortUrlIdentifier::fromShortCodeAndDomain($code, ''))->willReturn( $this->urlResolver->method('resolveEnabledShortUrl')->with(
ShortUrl::withLongUrl('https://shlink.io'), $this->equalTo(ShortUrlIdentifier::fromShortCodeAndDomain($code, '')),
); )->willReturn(ShortUrl::withLongUrl('https://shlink.io'));
$delegate = $this->prophesize(RequestHandlerInterface::class); $delegate = $this->createMock(RequestHandlerInterface::class);
$resp = $this->action($defaultOptions)->process($req, $delegate->reveal()); $resp = $this->action($defaultOptions)->process($req, $delegate);
$image = imagecreatefromstring($resp->getBody()->__toString()); $image = imagecreatefromstring($resp->getBody()->__toString());
$color = imagecolorat($image, 1, 1); $color = imagecolorat($image, 1, 1);
@ -246,7 +237,7 @@ class QrCodeActionTest extends TestCase
public function action(?QrCodeOptions $options = null): QrCodeAction public function action(?QrCodeOptions $options = null): QrCodeAction
{ {
return new QrCodeAction( return new QrCodeAction(
$this->urlResolver->reveal(), $this->urlResolver,
new ShortUrlStringifier(['domain' => 'doma.in']), new ShortUrlStringifier(['domain' => 'doma.in']),
new NullLogger(), new NullLogger(),
$options ?? new QrCodeOptions(), $options ?? new QrCodeOptions(),