OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Migrated LocateUnlocatedVisitsTest to use PHPUnit mocks

Browse Source
This commit is contained in:
Alejandro Celaya
2022-10-22 07:34:38 +02:00
parent cad53e397a
commit d07104b8d9
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
module/Core/test/EventDispatcher/LocateUnlocatedVisitsTest.php
View File

@@ -4,9 +4,8 @@ declare(strict_types=1);
namespace ShlinkioTest\Shlink\Core\EventDispatcher; namespace ShlinkioTest\Shlink\Core\EventDispatcher;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Core\EventDispatcher\Event\GeoLiteDbCreated; use Shlinkio\Shlink\Core\EventDispatcher\Event\GeoLiteDbCreated;
use Shlinkio\Shlink\Core\EventDispatcher\LocateUnlocatedVisits; use Shlinkio\Shlink\Core\EventDispatcher\LocateUnlocatedVisits;
use Shlinkio\Shlink\Core\Visit\Entity\Visit; use Shlinkio\Shlink\Core\Visit\Entity\Visit;
@@ -17,25 +16,23 @@ use Shlinkio\Shlink\IpGeolocation\Model\Location;
class LocateUnlocatedVisitsTest extends TestCase class LocateUnlocatedVisitsTest extends TestCase
{ {
use ProphecyTrait;
private LocateUnlocatedVisits $listener; private LocateUnlocatedVisits $listener;
private ObjectProphecy $locator; private MockObject $locator;
private ObjectProphecy $visitToLocation; private MockObject $visitToLocation;
protected function setUp(): void protected function setUp(): void
{ {
$this->locator = $this->prophesize(VisitLocatorInterface::class); $this->locator = $this->createMock(VisitLocatorInterface::class);
$this->visitToLocation = $this->prophesize(VisitToLocationHelperInterface::class); $this->visitToLocation = $this->createMock(VisitToLocationHelperInterface::class);
$this->listener = new LocateUnlocatedVisits($this->locator->reveal(), $this->visitToLocation->reveal()); $this->listener = new LocateUnlocatedVisits($this->locator, $this->visitToLocation);
} }
/** @test */ /** @test */
public function locatorIsCalledWhenInvoked(): void public function locatorIsCalledWhenInvoked(): void
{ {
$this->locator->expects($this->once())->method('locateUnlocatedVisits')->with($this->equalTo($this->listener));
($this->listener)(new GeoLiteDbCreated()); ($this->listener)(new GeoLiteDbCreated());
$this->locator->locateUnlocatedVisits($this->listener)->shouldHaveBeenCalledOnce();
} }
/** @test */ /** @test */
@@ -44,11 +41,12 @@ class LocateUnlocatedVisitsTest extends TestCase
$visit = Visit::forBasePath(Visitor::emptyInstance()); $visit = Visit::forBasePath(Visitor::emptyInstance());
$location = Location::emptyInstance(); $location = Location::emptyInstance();
$resolve = $this->visitToLocation->resolveVisitLocation($visit)->willReturn($location); $this->visitToLocation->expects($this->once())->method('resolveVisitLocation')->with(
$this->equalTo($visit),
)->willReturn($location);
$result = $this->listener->geolocateVisit($visit); $result = $this->listener->geolocateVisit($visit);
self::assertSame($location, $result); self::assertSame($location, $result);
$resolve->shouldHaveBeenCalledOnce();
} }
} }