OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-20 11:48:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Updated DeprecatedConfigParser to remove the secret key

Browse Source
This commit is contained in:
Alejandro Celaya 2020-01-01 11:27:09 +01:00
parent 16d9c3b93f
commit d205405dcc
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
module/Core/src/Config/DeprecatedConfigParser.php
View File

@ -10,7 +10,7 @@ class DeprecatedConfigParser
{
public function __invoke(array $config): array
{
return compose([$this, 'parseNotFoundRedirect'])($config);
return compose([$this, 'parseNotFoundRedirect'], [$this, 'removeSecretKey'])($config);
}
public function parseNotFoundRedirect(array $config): array
@ -30,4 +30,11 @@ class DeprecatedConfigParser
return $config;
}
public function removeSecretKey(array $config): array
{
// Removing secret_key from any generated config will prevent the AppOptions object from crashing
unset($config['app_options']['secret_key']);
return $config;
}
}

17
module/Core/test/Config/DeprecatedConfigParserTest.php
View File

@ -91,4 +91,21 @@ class DeprecatedConfigParserTest extends TestCase
$this->assertEquals($expected, $result);
}
/** @test */
public function removesTheOldSecretKey(): void
{
$config = [
'app_options' => [
'secret_key' => 'foobar',
],
];
$expected = [
'app_options' => [],
];
$result = ($this->postProcessor)($config);
$this->assertEquals($expected, $result);
}
}