From e1222de05b2fe2ebe44570de36b7a45d483a409b Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandro@alejandrocelaya.com>
Date: Sun, 28 Oct 2018 08:07:33 +0100
Subject: [PATCH] Explicitly imported global functions in UrlShortener

---
 module/Core/src/Service/UrlShortener.php | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/module/Core/src/Service/UrlShortener.php b/module/Core/src/Service/UrlShortener.php
index 1d207496..a54ae6a9 100644
--- a/module/Core/src/Service/UrlShortener.php
+++ b/module/Core/src/Service/UrlShortener.php
@@ -18,6 +18,11 @@ use Shlinkio\Shlink\Core\Exception\NonUniqueSlugException;
 use Shlinkio\Shlink\Core\Exception\RuntimeException;
 use Shlinkio\Shlink\Core\Repository\ShortUrlRepository;
 use Shlinkio\Shlink\Core\Util\TagManagerTrait;
+use Throwable;
+use function floor;
+use function fmod;
+use function preg_match;
+use function strlen;
 
 class UrlShortener implements UrlShortenerInterface
 {
@@ -101,7 +106,7 @@ class UrlShortener implements UrlShortenerInterface
 
             $this->em->commit();
             return $shortUrl;
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
             if ($this->em->getConnection()->isTransactionActive()) {
                 $this->em->rollback();
                 $this->em->close();
@@ -137,13 +142,13 @@ class UrlShortener implements UrlShortenerInterface
     private function convertAutoincrementIdToShortCode(float $id): string
     {
         $id += self::ID_INCREMENT; // Increment the Id so that the generated shortcode is not too short
-        $length = \strlen($this->chars);
+        $length = strlen($this->chars);
         $code = '';
 
         while ($id > 0) {
             // Determine the value of the next higher character in the short code and prepend it
-            $code = $this->chars[(int) \fmod($id, $length)] . $code;
-            $id = \floor($id / $length);
+            $code = $this->chars[(int) fmod($id, $length)] . $code;
+            $id = floor($id / $length);
         }
 
         return $this->chars[(int) $id] . $code;
@@ -174,7 +179,7 @@ class UrlShortener implements UrlShortenerInterface
     public function shortCodeToUrl(string $shortCode): ShortUrl
     {
         // Validate short code format
-        if (! \preg_match('|[' . $this->chars . ']+|', $shortCode)) {
+        if (! preg_match('|[' . $this->chars . ']+|', $shortCode)) {
             throw InvalidShortCodeException::fromCharset($shortCode, $this->chars);
         }