OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-01-24 15:26:38 -06:00
Code Issues Packages Projects Releases Wiki Activity

Used more strict types in UrlShortener private methods

Browse Source
This commit is contained in:
Alejandro Celaya 2018-11-24 07:52:57 +01:00
parent 9f60c8dffe
commit f40349479e
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
module/Core/src/Service/UrlShortener.php
View File

@ -107,13 +107,7 @@ class UrlShortener implements UrlShortenerInterface
}
}
/**
* Tries to perform a GET request to provided url, returning true on success and false on failure
*
* @param UriInterface $url
* @return void
*/
private function checkUrlExists(UriInterface $url)
private function checkUrlExists(UriInterface $url): void
{
try {
$this->httpClient->request('GET', $url, ['allow_redirects' => [
@ -124,12 +118,6 @@ class UrlShortener implements UrlShortenerInterface
}
}
/**
* Generates the unique shortcode for an autoincrement ID
*
* @param float $id
* @return string
*/
private function convertAutoincrementIdToShortCode(float $id): string
{
$id += self::ID_INCREMENT; // Increment the Id so that the generated shortcode is not too short
@ -145,7 +133,7 @@ class UrlShortener implements UrlShortenerInterface
return $this->chars[(int) $id] . $code;
}
private function processCustomSlug($customSlug)
private function processCustomSlug(?string $customSlug): ?string
{
if ($customSlug === null) {
return null;