OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improved GetShortUrlVisitsCommand test

Browse Source
This commit is contained in:
Alejandro Celaya 2022-05-24 17:43:13 +02:00
parent 353ac0fc0c
commit fba7b36245
1 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
module/CLI/test/Command/ShortUrl/GetVisitsCommandTest.php → module/CLI/test/Command/ShortUrl/GetShortUrlVisitsCommandTest.php
View File

@ -23,9 +23,10 @@ use Shlinkio\Shlink\IpGeolocation\Model\Location;
use ShlinkioTest\Shlink\CLI\CliTestUtilsTrait; use ShlinkioTest\Shlink\CLI\CliTestUtilsTrait;
use Symfony\Component\Console\Tester\CommandTester; use Symfony\Component\Console\Tester\CommandTester;
use function Shlinkio\Shlink\Common\buildDateRange;
use function sprintf; use function sprintf;
class GetVisitsCommandTest extends TestCase class GetShortUrlVisitsCommandTest extends TestCase
{ {
use CliTestUtilsTrait; use CliTestUtilsTrait;
@ -61,7 +62,7 @@ class GetVisitsCommandTest extends TestCase
$endDate = '2016-02-01'; $endDate = '2016-02-01';
$this->visitsHelper->visitsForShortUrl( $this->visitsHelper->visitsForShortUrl(
ShortUrlIdentifier::fromShortCodeAndDomain($shortCode), ShortUrlIdentifier::fromShortCodeAndDomain($shortCode),
new VisitsParams(DateRange::withStartAndEndDate(Chronos::parse($startDate), Chronos::parse($endDate))), new VisitsParams(buildDateRange(Chronos::parse($startDate), Chronos::parse($endDate))),
) )
->willReturn(new Paginator(new ArrayAdapter([]))) ->willReturn(new Paginator(new ArrayAdapter([])))
->shouldBeCalledOnce(); ->shouldBeCalledOnce();
@ -99,23 +100,32 @@ class GetVisitsCommandTest extends TestCase
/** @test */ /** @test */
public function outputIsProperlyGenerated(): void public function outputIsProperlyGenerated(): void
{ {
$visit = Visit::forValidShortUrl(ShortUrl::createEmpty(), new Visitor('bar', 'foo', '', ''))->locate(
VisitLocation::fromGeolocation(new Location('', 'Spain', '', 'Madrid', 0, 0, '')),
);
$shortCode = 'abc123'; $shortCode = 'abc123';
$this->visitsHelper->visitsForShortUrl( $this->visitsHelper->visitsForShortUrl(
ShortUrlIdentifier::fromShortCodeAndDomain($shortCode), ShortUrlIdentifier::fromShortCodeAndDomain($shortCode),
Argument::any(), Argument::any(),
)->willReturn( )->willReturn(
new Paginator(new ArrayAdapter([ new Paginator(new ArrayAdapter([$visit])),
Visit::forValidShortUrl(ShortUrl::createEmpty(), new Visitor('bar', 'foo', '', ''))->locate(
VisitLocation::fromGeolocation(new Location('', 'Spain', '', 'Madrid', 0, 0, '')),
),
])),
)->shouldBeCalledOnce(); )->shouldBeCalledOnce();
$this->commandTester->execute(['shortCode' => $shortCode]); $this->commandTester->execute(['shortCode' => $shortCode]);
$output = $this->commandTester->getDisplay(); $output = $this->commandTester->getDisplay();
self::assertStringContainsString('foo', $output);
self::assertStringContainsString('Spain', $output); echo $output;
self::assertStringContainsString('Madrid', $output);
self::assertStringContainsString('bar', $output); self::assertEquals(
<<<OUTPUT
+---------+---------------------------+------------+---------+--------+
| Referer | Date | User agent | Country | City |
+---------+---------------------------+------------+---------+--------+
| foo | {$visit->getDate()->toAtomString()} | bar | Spain | Madrid |
+---------+---------------------------+------------+---------+--------+
OUTPUT,
$output,
);
} }
} }