OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-12-28 09:51:40 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improved BodyParserMiddlewareTest to kill more mutants

Browse Source
This commit is contained in:
Alejandro Celaya 2019-12-01 10:58:48 +01:00
parent 46c0620236
commit fc5904e743
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
module/Rest/test/Middleware/BodyParserMiddlewareTest.php
View File

@ -6,6 +6,7 @@ namespace ShlinkioTest\Shlink\Rest\Middleware;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument; use Prophecy\Argument;
use Prophecy\Prophecy\ProphecyInterface;
use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface; use Psr\Http\Server\RequestHandlerInterface;
use Shlinkio\Shlink\Rest\Middleware\BodyParserMiddleware; use Shlinkio\Shlink\Rest\Middleware\BodyParserMiddleware;
@ -31,7 +32,10 @@ class BodyParserMiddlewareTest extends TestCase
*/ */
public function requestsFromOtherMethodsJustFallbackToNextMiddleware(string $method): void public function requestsFromOtherMethodsJustFallbackToNextMiddleware(string $method): void
{ {
$request = (new ServerRequest())->withMethod($method); $request = $this->prophesize(ServerRequestInterface::class);
$request->getMethod()->willReturn($method);
$request->getParsedBody()->willReturn([]);
$this->assertHandlingRequestJustFallsBackToNext($request); $this->assertHandlingRequestJustFallsBackToNext($request);
} }
@ -45,18 +49,25 @@ class BodyParserMiddlewareTest extends TestCase
/** @test */ /** @test */
public function requestsWithNonEmptyBodyJustFallbackToNextMiddleware(): void public function requestsWithNonEmptyBodyJustFallbackToNextMiddleware(): void
{ {
$request = (new ServerRequest())->withParsedBody(['foo' => 'bar'])->withMethod('POST'); $request = $this->prophesize(ServerRequestInterface::class);
$request->getMethod()->willReturn('POST');
$request->getParsedBody()->willReturn(['foo' => 'bar']);
$this->assertHandlingRequestJustFallsBackToNext($request); $this->assertHandlingRequestJustFallsBackToNext($request);
} }
private function assertHandlingRequestJustFallsBackToNext(ServerRequestInterface $request): void private function assertHandlingRequestJustFallsBackToNext(ProphecyInterface $requestMock): void
{ {
$getContentType = $requestMock->getHeaderLine('Content-type')->willReturn('');
$request = $requestMock->reveal();
$nextHandler = $this->prophesize(RequestHandlerInterface::class); $nextHandler = $this->prophesize(RequestHandlerInterface::class);
$handle = $nextHandler->handle($request)->willReturn(new Response()); $handle = $nextHandler->handle($request)->willReturn(new Response());
$this->middleware->process($request, $nextHandler->reveal()); $this->middleware->process($request, $nextHandler->reveal());
$handle->shouldHaveBeenCalledOnce(); $handle->shouldHaveBeenCalledOnce();
$getContentType->shouldNotHaveBeenCalled();
} }
/** @test */ /** @test */