if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2024-12-29 02:11:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

electron-258: fixes the pop out issue for meetings and supports undefined urls in case of new window events as per the html dom specs

Browse Source
This commit is contained in:
Vishwas Shashidhar 2018-01-02 17:00:12 +05:30
parent ed4672d0bc
commit 0edc3d01e2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/windowMgr.js
View File

@ -311,7 +311,7 @@ function doCreateMainWindow(initialUrl, initialBounds) {
// open external links in default browser - a tag with href='_blank' or window.open
mainWindow.webContents.on('new-window', function (event, newWinUrl,
frameName, disposition, newWinOptions) {
let newWinParsedUrl = getParsedUrl(newWinUrl);
let mainWinParsedUrl = getParsedUrl(url);
@ -320,7 +320,7 @@ function doCreateMainWindow(initialUrl, initialBounds) {
// only allow window.open to succeed is if coming from same hsot,
// otherwise open in default browser.
if (disposition === 'new-window' && newWinHost === mainWinHost) {
if (disposition === 'new-window' && ((newWinHost === mainWinHost) || newWinUrl === 'about:blank')) {
// handle: window.open
if (!frameName) {