if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-01-15 11:12:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix test failures for newer ver of node (#42)

Browse Source
This commit is contained in:
Lynn 2017-03-24 16:18:09 -07:00 committed by GitHub
parent e9422de1c2
commit 1f149d62c2
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/preload/createProxy.js
View File

@ -234,7 +234,6 @@ function getHandler(target, property, isStatic) {
function instanceSetHandler(target, property, value) { function instanceSetHandler(target, property, value) {
let prototype = Object.getPrototypeOf(target); let prototype = Object.getPrototypeOf(target);
let desc = Object.getOwnPropertyDescriptor(prototype, property); let desc = Object.getOwnPropertyDescriptor(prototype, property);
if (desc && desc.set) { if (desc && desc.set) {
var args = { var args = {
objId: target._objId, objId: target._objId,
@ -243,7 +242,10 @@ function instanceSetHandler(target, property, value) {
} }
ipcRenderer.sendSync(proxyCmds.set, args); ipcRenderer.sendSync(proxyCmds.set, args);
return true;
} }
return false;
} }
function staticGetHandler(target, name) { function staticGetHandler(target, name) {

2
tests/apiTests/proxy-polyfill.js
View File

@ -19,6 +19,8 @@
* the License. * the License.
*/ */
// note: polyfill here can be removed when everyone is using node >= 6.4.0
'use strict'; 'use strict';
(function(scope) { (function(scope) {

2
tests/apiTests/proxyAPI.test.js
View File

@ -289,7 +289,7 @@ describe('proxy destroy tests...', function() {
}); });
}); });
test('destroy from implementation side', function() { test('destroy from implementation side', function(done) {
inst.close(); inst.close();
inst.getArg1() inst.getArg1()