if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

SDA-4036 Remove 1.5 related code for version discovery (#1662)

Browse Source
This commit is contained in:
Salah Benmoussati 2023-02-08 11:33:36 +01:00 committed by GitHub
parent 33664a8410
commit 20f0d92152
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/app/version-handler.ts
View File

@ -182,15 +182,10 @@ class VersionHandler {
/* Get SFE version */ /* Get SFE version */
let urlSfeVersion: string; let urlSfeVersion: string;
if (mainUrl?.includes('bff')) {
urlSfeVersion = mainUrl?.includes('/daily/') urlSfeVersion = mainUrl?.includes('/daily/')
? `${protocol}//${hostname}/bff-daily/daily/version.json` ? `${protocol}//${hostname}/bff-daily/daily/version.json`
: `${protocol}//${hostname}/client-bff/version.json`; : `${protocol}//${hostname}/client-bff/version.json`;
this.versionInfo.sfeClientType = '2.0'; this.versionInfo.sfeClientType = '2.0';
} else {
urlSfeVersion = `${protocol}//${hostname}/client/version.json`;
this.versionInfo.sfeClientType = '1.5';
}
logger.info( logger.info(
`version-handler: Trying to get SFE version info for the URL: ${urlSfeVersion}`, `version-handler: Trying to get SFE version info for the URL: ${urlSfeVersion}`,
); );

9
src/renderer/components/about-app.tsx
View File

@ -35,6 +35,7 @@ interface IState {
} }
const ABOUT_SYMPHONY_NAMESPACE = 'AboutSymphony'; const ABOUT_SYMPHONY_NAMESPACE = 'AboutSymphony';
const SFE_CLIENT_TYPE_NAME = 'SFE-Lite';
/** /**
* Window that display app version and copyright info * Window that display app version and copyright info
@ -85,7 +86,6 @@ export default class AboutApp extends React.Component<{}, IState> {
buildNumber, buildNumber,
hostname, hostname,
sfeVersion, sfeVersion,
sfeClientType,
sdaVersion, sdaVersion,
sdaBuildNumber, sdaBuildNumber,
client, client,
@ -98,7 +98,6 @@ export default class AboutApp extends React.Component<{}, IState> {
)()} \xA9 ${new Date().getFullYear()} ${appName}`; )()} \xA9 ${new Date().getFullYear()} ${appName}`;
const podVersion = `${clientVersion} (${buildNumber})`; const podVersion = `${clientVersion} (${buildNumber})`;
const sdaVersionBuild = `${sdaVersion} (${sdaBuildNumber})`; const sdaVersionBuild = `${sdaVersion} (${sdaBuildNumber})`;
let sfeClientTypeName = 'SFE-Lite';
const symphonySectionItems = [ const symphonySectionItems = [
{ {
key: 'POD:', key: 'POD:',
@ -113,15 +112,11 @@ export default class AboutApp extends React.Component<{}, IState> {
value: sdaVersionBuild, value: sdaVersionBuild,
}, },
{ {
key: `${sfeClientTypeName}:`, key: `${SFE_CLIENT_TYPE_NAME}:`,
value: `${sfeVersion} ${client}`, value: `${sfeVersion} ${client}`,
}, },
]; ];
if (sfeClientType !== '1.5') {
sfeClientTypeName = 'SFE-Lite';
}
return ( return (
<div className='AboutApp' lang={i18n.getLocale()}> <div className='AboutApp' lang={i18n.getLocale()}>
<div className='AboutApp-header-container'> <div className='AboutApp-header-container'>