fix: ELECTRON-1264 (Fix ATS for localhost and update TLS version to 1.2) (#689)

* ELECTRON-1264 - Fix ATS for localhost and update tls version to 1.2

* ELECTRON-1264 - Remove extendInfo field from package.json

config/Symphony.config

@@ -13,11 +13,6 @@
         "position": "upper-right",
         "display": ""
     },
-    "crashReporter": {
-        "submitURL": "https://localhost:1127/post",
-        "companyName": "Symphony",
-        "uploadToServer": false
-    },
     "customFlags": {
         "authServerWhitelist": "",
         "authNegotiateDelegateWhitelist": "",

src/app/chrome-flags.ts

@@ -3,6 +3,10 @@ import { logger } from '../common/logger';
 import { getCommandLineArgs } from '../common/utils';
 import { config, IConfig } from './config-handler';
 
+// Set default flags
+logger.info(`chrome-flags: Setting mandatory chrome flags`, { flag: { 'ssl-version-fallback-min': 'tls1.2' } });
+app.commandLine.appendSwitch('ssl-version-fallback-min', 'tls1.2');
+
 /**
  * Sets chrome flags
  */

src/app/config-handler.ts

@@ -38,7 +38,6 @@ export interface IConfig {
     notificationSettings: INotificationSetting;
     permissions: IPermission;
     customFlags: ICustomFlag;
-    crashReporter: ICrashReporter;
     mainWinPos?: ICustomRectangle;
 }
 
@@ -58,12 +57,6 @@ export interface ICustomFlag {
     disableGpu: boolean;
 }
 
-export interface ICrashReporter {
-    submitURL: string;
-    companyName: string;
-    uploadToServer: boolean;
-}
-
 export interface INotificationSetting {
     position: string;
     display: string;

src/app/window-handler.ts

@@ -178,7 +178,7 @@ export class WindowHandler {
     constructor(opts?: Electron.BrowserViewConstructorOptions) {
         // Use these variables only on initial setup
         this.config = config.getConfigFields([ 'isCustomTitleBar', 'mainWinPos', 'minimizeOnClose', 'notificationSettings' ]);
-        this.globalConfig = config.getGlobalConfigFields([ 'url', 'crashReporter' ]);
+        this.globalConfig = config.getGlobalConfigFields([ 'url' ]);
 
         this.windows = {};
         this.isCustomTitleBar = isWindowsOS && this.config.isCustomTitleBar;
@@ -190,7 +190,8 @@ export class WindowHandler {
 
         try {
             const extra = { podUrl: this.globalConfig.url, process: 'main' };
-            crashReporter.start({ ...this.globalConfig.crashReporter, extra });
+            const defaultOpts = { uploadToServer: false, companyName: 'Symphony', submitURL: '' };
+            crashReporter.start({ ...defaultOpts, extra });
         } catch (e) {
             throw new Error('failed to init crash report');
         }