if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1067 from mattias-symphony/SDA-2393

Browse Source 
feat: SDA-2393 Adding/removing registry keys
This commit is contained in:
mattias-symphony 2020-09-09 13:27:11 +02:00 committed by GitHub
commit 3749b2e70c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 89 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
installer/win/WixSharpInstaller/Symphony.cs
View File

@ -11,6 +11,7 @@
using WixSharp; using WixSharp;
using WixSharp.Forms; using WixSharp.Forms;
using Microsoft.Deployment.WindowsInstaller; using Microsoft.Deployment.WindowsInstaller;
using Microsoft.Win32;
class Script class Script
{ {
@ -107,7 +108,10 @@ class Script
// Add a launch condition to require Windows Server 2008 or later // Add a launch condition to require Windows Server 2008 or later
// The property values to compare against can be found here: // The property values to compare against can be found here:
// https://docs.microsoft.com/en-us/windows/win32/msi/operating-system-property-values // https://docs.microsoft.com/en-us/windows/win32/msi/operating-system-property-values
new LaunchCondition("VersionNT>=600 AND WindowsBuild>=6001", "OS not supported") new LaunchCondition("VersionNT>=600 AND WindowsBuild>=6001", "OS not supported"),
// Add registry entry used by protocol handler to launch symphony when opening symphony:// URIs
new RegValue(WixSharp.RegistryHive.ClassesRoot, productName + @"\shell\open\command", "", "\"[INSTALLDIR]Symphony.exe\" \"%1\"")
); );
// The build script which calls the wix# builder, will be run from a command environment which has %SYMVER% set. // The build script which calls the wix# builder, will be run from a command environment which has %SYMVER% set.
@ -164,7 +168,14 @@ class Script
{ {
// The UpdateConfig action needs the built-in property INSTALLDIR as well as most of the custom properties // The UpdateConfig action needs the built-in property INSTALLDIR as well as most of the custom properties
UsesProperties = "INSTALLDIR,POD_URL,MINIMIZE_ON_CLOSE,ALWAYS_ON_TOP,AUTO_START,BRING_TO_FRONT,MEDIA,LOCATION,NOTIFICATIONS,MIDI_SYSEX,POINTER_LOCK,FULL_SCREEN,OPEN_EXTERNAL,CUSTOM_TITLE_BAR,DEV_TOOLS_ENABLED,AUTO_LAUNCH_PATH" UsesProperties = "INSTALLDIR,POD_URL,MINIMIZE_ON_CLOSE,ALWAYS_ON_TOP,AUTO_START,BRING_TO_FRONT,MEDIA,LOCATION,NOTIFICATIONS,MIDI_SYSEX,POINTER_LOCK,FULL_SCREEN,OPEN_EXTERNAL,CUSTOM_TITLE_BAR,DEV_TOOLS_ENABLED,AUTO_LAUNCH_PATH"
} },
// CleanRegistry
//
// We have some registry keys which are added by the SDA application when it is first launched. This custom
// action will clean up those keys on uninstall. The name/location of keys have changed between different
// versions of SDA, so we clean up all known variations, and ignore any missing ones.
new ElevatedManagedAction(CustomActions.CleanRegistry, Return.ignore, When.After, Step.RemoveFiles, Condition.Installed )
}; };
// Use our own Symphony branded bitmap for installation dialogs // Use our own Symphony branded bitmap for installation dialogs
@ -177,6 +188,10 @@ class Script
.Add(Dialogs.InstallDir) .Add(Dialogs.InstallDir)
.Add(Dialogs.Progress) .Add(Dialogs.Progress)
.Add<Symphony.ExitDlg>(); .Add<Symphony.ExitDlg>();
project.ManagedUI.ModifyDialogs.Add(Dialogs.MaintenanceType)
.Add(Dialogs.Progress)
.Add<Symphony.ExitDlg>();
// Generate an MSI from all settings done above // Generate an MSI from all settings done above
@ -265,4 +280,61 @@ public class CustomActions
@"""" + name + @""":""" + value.Trim() + @""""); @"""" + name + @""":""" + value.Trim() + @"""");
} }
// CleanRegistry custom action
[CustomAction]
public static ActionResult CleanRegistry(Session session)
{
try
{
// Remove registry keys added for auto-launch
using( var key = Registry.CurrentUser.OpenSubKey(@"Software\Microsoft\Windows\CurrentVersion\Run", true) )
{
if (key != null)
{
key.DeleteValue("Symphony", false);
key.DeleteValue("com.symphony.electron-desktop", false);
key.DeleteValue("electron.app.Symphony", false);
}
}
using( var key = Registry.Users.OpenSubKey(@"\.DEFAULT\Software\Microsoft\Windows\CurrentVersion\Run", true) )
{
if (key != null)
{
key.DeleteValue("Symphony", false);
}
}
// Remove registry keys added by protocol handlers
using( var key = Registry.CurrentUser.OpenSubKey(@"Software\Classes", true) )
{
if (key != null)
{
key.DeleteSubKeyTree("symphony", false);
}
}
using( var key = Registry.LocalMachine.OpenSubKey(@"Software\Classes", true) )
{
if (key != null)
{
key.DeleteSubKeyTree("symphony", false);
}
}
using( var key = Registry.ClassesRoot.OpenSubKey(@"\", true) )
{
if (key != null)
{
key.DeleteSubKeyTree("symphony", false);
}
}
}
catch (System.Exception e)
{
session.Log("Error executing CleanRegistry: " + e.ToString() );
return ActionResult.Success;
}
return ActionResult.Success;
}
} }