if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

SDA-4562 (Managed condition should always run) (#2162)

Browse Source 
* SDA-4562 - Change the condition to run always

* SDA-4562 - Clean NSIS registry for any install dir

* SDA-4562 - Add missing return
This commit is contained in:
Kiran Niranjan 2024-06-06 13:50:25 +05:30 committed by GitHub
parent c999e279b6
commit 409f7d0b0e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 37 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
installer/win/WixSharpInstaller/Symphony.cs
View File

@ -174,7 +174,7 @@ class Script
// CleanNSISRegistryForCurrentUser
//
// This custom action is to remove any registry entries from HKEY_CURRENT_USER if exists
new ManagedAction(CustomActions.CleanNSISRegistryForCurrentUser, Return.check, When.Before, Step.LaunchConditions, Condition.NOT_Installed )
new ManagedAction(CustomActions.CleanNSISRegistryForCurrentUser, Return.check, When.Before, Step.LaunchConditions, Condition.Always )
{
UsesProperties = "INSTALLDIR"
},
@ -531,59 +531,55 @@ public class CustomActions
[CustomAction]
public static ActionResult CleanNSISRegistryForCurrentUser(Session session)
{
// Check if the INSTALLDIR starts with the per user installation path
if (session["INSTALLDIR"].StartsWith(System.Environment.ExpandEnvironmentVariables(@"%LOCALAPPDATA%\Programs\")))
try
{
try
const string uninstallKey = @"SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall";
const string displayNameValue = "Symphony";
// Open the Uninstall key
using (var key = Registry.CurrentUser.OpenSubKey(uninstallKey))
{
const string uninstallKey = @"SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall";
const string displayNameValue = "Symphony";
// Open the Uninstall key
using (var key = Registry.CurrentUser.OpenSubKey(uninstallKey))
if (key == null)
{
if (key == null)
{
session.Log("Uninstall key not found.");
return ActionResult.Success;
}
session.Log("Uninstall key not found.");
return ActionResult.Success;
}
// Iterate through all subkeys
foreach (string subkeyName in key.GetSubKeyNames())
// Iterate through all subkeys
foreach (string subkeyName in key.GetSubKeyNames())
{
using (var subkey = key.OpenSubKey(subkeyName))
{
using (var subkey = key.OpenSubKey(subkeyName))
if (subkey == null)
{
if (subkey == null)
{
continue;
}
continue;
}
// Get the DisplayName value
string displayName = subkey.GetValue("DisplayName") as string;
if (displayName == displayNameValue)
// Get the DisplayName value
string displayName = subkey.GetValue("DisplayName") as string;
if (displayName == displayNameValue)
{
// Get the UninstallString value
string uninstallString = subkey.GetValue("QuietUninstallString") as string;
if (!string.IsNullOrEmpty(uninstallString))
{
// Get the UninstallString value
string uninstallString = subkey.GetValue("QuietUninstallString") as string;
if (!string.IsNullOrEmpty(uninstallString))
{
// Start the uninstallation process
var process = new System.Diagnostics.Process();
process.StartInfo.FileName = "cmd.exe";
process.StartInfo.Arguments = string.Format("/c \"{0}\"", uninstallString);
process.StartInfo.UseShellExecute = false;
process.Start();
process.WaitForExit();
}
// Start the uninstallation process
var process = new System.Diagnostics.Process();
process.StartInfo.FileName = "cmd.exe";
process.StartInfo.Arguments = string.Format("/c \"{0}\"", uninstallString);
process.StartInfo.UseShellExecute = false;
process.Start();
process.WaitForExit();
}
}
}
}
}
catch (System.Exception e)
{
session.Log("Error executing CleanNSISRegistryForCurrentUser: " + e.ToString());
return ActionResult.Success;
}
}
catch (System.Exception e)
{
session.Log("Error executing CleanNSISRegistryForCurrentUser: " + e.ToString());
return ActionResult.Success;
}
return ActionResult.Success;
}