Merge pull request #1211 from mattias-symphony/SDA-3102

SDA-3102 Added support for LAUNCH_ON_INSTALL installation parameter

RELEASE_NOTES.md

@@ -1,7 +1,19 @@
 # Release notes
 
+---
+
+## SDA 9.3.x
+
+### 9.3.0
+
+- [CORE - Natwest - Prod - Unable to take screenshot of one Application](https://perzoinc.atlassian.net/browse/sda-3079)
+- [State Street - Create a Property to suppress SDA from starting post install](https://perzoinc.atlassian.net/browse/sda-3102}
+
+* 9.4.1 (Electron-version)
+* 83 (Chromium-version)
+
+---
 
--------------------------------------------------------------------
 ## SDA 9.2.x
 
 ### 9.2.0
@@ -10,10 +22,11 @@
 2. [SDA-2404 CLIENT Toast Action: Phase 1](https://perzoinc.atlassian.net/browse/SDA-2404)
 3. [SDA-2385 CORE Windows Wix installer](https://perzoinc.atlassian.net/browse/SDA-2385)
 
-* 9.3.5 (Electron-version)
-* 83    (Chromium-version)
+- 9.3.5 (Electron-version)
+- 83 (Chromium-version)
+
+---
 
--------------------------------------------------------------------
 ## SDA 9.1.x
 
 ### SDA 9.1.4
@@ -21,8 +34,8 @@
 1. [SDA-2694 Point72 blank screen windows-only](https://perzoinc.atlassian.net/browse/SDA-2694)
 2. [SDA-2731 Blank screen after upgrade (fresh installation) windows-only](https://perzoinc.atlassian.net/browse/SDA-2731)
 
-* 9.3.5 (Electron-version)
-* 83    (Chromium-version)
+- 9.3.5 (Electron-version)
+- 83 (Chromium-version)
 
 ### SDA 9.1.3
 
@@ -31,8 +44,8 @@
 3. [SDA-2524 CORE Unpreventable top-level navigation](https://perzoinc.atlassian.net/browse/SDA-2524)
 4. [SDA-2525 CORE Context isolation bypass via prevented window.open](https://perzoinc.atlassian.net/browse/SDA-2525)
 
-* 9.3.2 (Electron-version)
-* 83    (Chromium-version)
+- 9.3.2 (Electron-version)
+- 83 (Chromium-version)
 
 ### SDA 9.1.2
 
@@ -41,24 +54,24 @@
 3. [SDA-2406 CORE GS Prod: Mac SDA 6.1 polling for python3, pip3 and other packages](https://perzoinc.atlassian.net/browse/SDA-2406)
 4. [SDA-2465 CORE GS - SDA/RTC - Exception when started Screen Share](https://perzoinc.atlassian.net/browse/SDA-2465)
 
-* 9.2.1 (Electron-version)
-* 83    (Chromium-version)
+- 9.2.1 (Electron-version)
+- 83 (Chromium-version)
+
+---
 
--------------------------------------------------------------------
 ## SDA 9.0.x
 
 ### SDA 9.0.3
 
 1. [SDA-2287 Context Isolation: Missing Hamburger menu when setting contextIsolation = false](https://perzoinc.atlassian.net/browse/SDA-2287)
 2. [SDA-2285 Memory Refresh: Update electron API to support memory refresh in 9.x version](https://perzoinc.atlassian.net/browse/SDA-2285)
-3. [RTC-8098 RTC/SDA:  "Meeting failed" to many meetings from SDA 9.0.x](https://perzoinc.atlassian.net/browse/RTC-8098)
+3. [RTC-8098 RTC/SDA: "Meeting failed" to many meetings from SDA 9.0.x](https://perzoinc.atlassian.net/browse/RTC-8098)
 4. [SDA-2229 [WFC] Unable to login to Symphony on SDA but able to login using Chrome on a macOS](https://perzoinc.atlassian.net/browse/SDA-2229)
 
-* 9.2.1 (Electron-version)
-* 83    (Chromium-version)
-
+- 9.2.1 (Electron-version)
+- 83 (Chromium-version)
 
 ### SDA 9.0.0
 
-* 9.0.2 (Electron-version)
-* 83    (Chromium-version)
+- 9.0.2 (Electron-version)
+- 83 (Chromium-version)

installer/win/WixSharpInstaller/Symphony.cs

@@ -166,6 +166,7 @@ class Script
             new PublicProperty("DEV_TOOLS_ENABLED", "true"),
             new PublicProperty("FULL_SCREEN", "true"),
             new PublicProperty("LOCATION", "true"),
+            new PublicProperty("LAUNCH_ON_INSTALL", "true"),
             new PublicProperty("MEDIA", "true"),
             new PublicProperty("MIDI_SYSEX", "true"),
             new PublicProperty("MINIMIZE_ON_CLOSE", "ENABLED"),
@@ -220,7 +221,10 @@ class Script
             new ManagedAction(CustomActions.CleanRegistryCurrentUser, Return.ignore, When.After, Step.RemoveFiles, Condition.BeingUninstalled ),
 
             // Start Symphony after installation is complete
-            new InstalledFileAction(new Id("symphony_exe"), "", Return.asyncNoWait, When.After, Step.InstallFinalize, Condition.NOT_BeingRemoved)
+            new ManagedAction(CustomActions.StartAfterInstall, Return.ignore, When.After, Step.InstallFinalize, Condition.NOT_BeingRemoved )
+            {
+                UsesProperties = "INSTALLDIR,LAUNCH_ON_INSTALL"
+            },
         };
 
         // Use our own Symphony branded bitmap for installation dialogs
@@ -470,4 +474,25 @@ public class CustomActions
         }
         return ActionResult.Success;
     }
+
+    // StartAfterInstall custom action
+    [CustomAction]
+    public static ActionResult StartAfterInstall(Session session)
+    {
+        try
+        {
+            if (session.Property("LAUNCH_ON_INSTALL")=="true") 
+            {
+                System.Diagnostics.Process process = new System.Diagnostics.Process();
+                process.StartInfo.FileName =  System.IO.Path.Combine(session.Property("INSTALLDIR"), "Symphony.exe");
+                process.Start();
+            }
+        }
+        catch (System.Exception e)
+        {
+            session.Log("Error executing StartAfterInstall: " + e.ToString() );
+            return ActionResult.Failure;
+        }
+        return ActionResult.Success;
+    }
 }

installer/win/install_instructions_win.md

@@ -209,6 +209,30 @@ or
 
 
 
+-------------------------------------------------------------------
+### LAUNCH_ON_INSTALL
+
+Expected values:
+
+* "true"
+  Symphony will be launched automatically after installation has completed (default)
+* "false"
+  Symphony will not be launched after installation has completed
+
+#### Example, install with launch on install enabled
+
+    msiexec /i Symphony.msi LAUNCH_ON_INSTALL="true"
+
+or
+
+    msiexec /i Symphony.msi /q
+
+#### Example, install with launch on install disabled
+
+    msiexec /i Symphony.msi LAUNCH_ON_INSTALL="false"
+
+
+
 -------------------------------------------------------------------
 ### LOCATION