From dbe9915b3f5e9a700dadd6eaec9c9554b10a4d91 Mon Sep 17 00:00:00 2001 From: Johan Kwarnmark Date: Tue, 28 Jul 2020 18:08:22 +0200 Subject: [PATCH 1/2] Enable E2E encryption api in webRTC --- src/app/chrome-flags.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/chrome-flags.ts b/src/app/chrome-flags.ts index 49568bf5..efbf21ad 100644 --- a/src/app/chrome-flags.ts +++ b/src/app/chrome-flags.ts @@ -25,6 +25,7 @@ export const setChromeFlags = () => { 'disable-d3d11': flagsConfig.disableGpu || null, 'disable-gpu': flagsConfig.disableGpu || null, 'disable-gpu-compositing': flagsConfig.disableGpu || null, + 'enable-experimental-web-platform-features': 'true', }; if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) { configFlags['disable-renderer-backgrounding'] = 'true'; From b7292aa84e547598ef32dad532313867dd705162 Mon Sep 17 00:00:00 2001 From: Johan Kwarnmark Date: Wed, 29 Jul 2020 10:06:49 +0200 Subject: [PATCH 2/2] Update unit test regarding chrome flags to match the new flag added --- spec/chromeFlags.spec.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/spec/chromeFlags.spec.ts b/spec/chromeFlags.spec.ts index 96f6972e..6cfdc0f8 100644 --- a/spec/chromeFlags.spec.ts +++ b/spec/chromeFlags.spec.ts @@ -98,8 +98,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(5); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => { @@ -110,8 +110,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(7, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(8); + expect(spy).nthCalledWith(8, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(9); }); it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => { @@ -132,8 +132,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(5); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => { @@ -154,8 +154,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(5); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); describe('`isDevEnv`', () => {