if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

ELECTRON-1132 (Remove HKU registry entry on uninstalling the SDA) (#592)

Browse Source 
* ELECTRON-1132 - Remove HKU registry entry on uninstalling the SDA

* ELECTRON-1132 - Change logic to use build number instead of version number to validate first time launch

* ELECTRON-1132 - Remove config exits check as we gracefully create a new config file
This commit is contained in:
Kiran Niranjan
2019-03-13 16:32:55 +05:30
committed by Vishwas Shashidhar
parent 491a0ca24e
commit 71eb796139
4 changed files with 12 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
js/main.js
View File

@@ -24,7 +24,6 @@ const { setCheckboxValues } = require('./menus/menuTemplate.js');
const autoLaunch = require('./autoLaunch');
const { handleCacheFailureCheckOnStartup, handleCacheFailureCheckOnExit} = require('./cacheHandler');
const compareSemVersions = require('./utils/compareSemVersions.js');
const { isMac, isDevEnv } = require('./utils/misc.js');
const getCmdLineArg = require('./utils/getCmdLineArg.js');
@@ -314,24 +313,21 @@ function setupThenOpenMainWindow() {
function checkFirstTimeLaunch() {
return new Promise((resolve, reject) => {
getUserConfigField('configVersion')
.then((configVersion) => {
const appVersionString = app.getVersion().toString();
getUserConfigField('configBuildNumber')
.then((configBuildNumber) => {
const execPath = nodePath.dirname(app.getPath('exe'));
const shouldUpdateUserConfig = execPath.indexOf('AppData\\Local\\Programs') !== -1 || isMac;
if (!(configVersion
&& typeof configVersion === 'string'
&& (compareSemVersions.check(appVersionString, configVersion) !== 1))) {
if (configBuildNumber && typeof configBuildNumber === 'string' && configBuildNumber !== buildNumber) {
return setupFirstTimeLaunch(resolve, reject, shouldUpdateUserConfig);
}
log.send(logLevels.INFO, `not a first-time launch as
configVersion: ${configVersion} appVersion: ${appVersionString} shouldUpdateUserConfig: ${shouldUpdateUserConfig}`);
configBuildNumber: ${configBuildNumber} installerBuildNumber: ${buildNumber} shouldUpdateUserConfig: ${shouldUpdateUserConfig}`);
return resolve();
})
.catch((e) => {
log.send(logLevels.ERROR, `Error reading configVersion error: ${e}`);
return setupFirstTimeLaunch(resolve, reject, false);
return setupFirstTimeLaunch(resolve, reject, true);
});
});
}