From 74e5123e489f0e920a10bbc3e923bd190e2462ac Mon Sep 17 00:00:00 2001
From: Vishwas Shashidhar <VishwasShashidhar@users.noreply.github.com>
Date: Mon, 27 Aug 2018 20:28:21 +0530
Subject: [PATCH] ELECTRON-669: add japanese localisation for download manager
 actions (#477)

Currently, the actions "Open" & "Show in Folder" are not localised as part of the download manager. This commit adds japanese localisation for the above two actions.

Along with the above, we also add a better UX by using the string "Reveal in Finder" for macOS users.
---
 js/downloadManager/index.js | 21 +++++++++++++++++++--
 js/windowMgr.js             |  6 ++++++
 locale/en-US.json           |  5 +++++
 locale/en.json              |  5 +++++
 locale/ja-JP.json           |  5 +++++
 locale/ja.json              |  5 +++++
 6 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/js/downloadManager/index.js b/js/downloadManager/index.js
index f81fca4b..95ba8224 100644
--- a/js/downloadManager/index.js
+++ b/js/downloadManager/index.js
@@ -7,6 +7,9 @@ const local = {
     downloadItems: []
 };
 
+let showInFolderText = "Show in Folder";
+let openText = "Open";
+
 // listen for file download complete event
 local.ipcRenderer.on('downloadCompleted', (event, arg) => {
     createDOM(arg);
@@ -17,6 +20,20 @@ local.ipcRenderer.on('downloadProgress', () => {
     initiate();
 });
 
+// listen for locale change and update
+local.ipcRenderer.on('locale-changed', (event, data) => {
+
+    if (data && typeof data === 'object') {
+
+        if (data.downloadManager) {
+            showInFolderText = data.downloadManager['Show in Folder'];
+            openText = data.downloadManager.Open;
+        }
+
+    }
+
+});
+
 /**
  * Open file in default app.
  * @param id
@@ -137,7 +154,7 @@ function createDOM(arg) {
 
             let caretLiOpen = document.createElement('li');
             caretLiOpen.id = 'download-open';
-            caretLiOpen.innerHTML = 'Open';
+            caretLiOpen.innerHTML = openText;
             caretUL.appendChild(caretLiOpen);
             let openFileDocument = document.getElementById('download-open');
             openFileDocument.addEventListener('click', () => {
@@ -147,7 +164,7 @@ function createDOM(arg) {
 
             let caretLiShow = document.createElement('li');
             caretLiShow.id = 'download-show-in-folder';
-            caretLiShow.innerHTML = 'Show in Folder';
+            caretLiShow.innerHTML = showInFolderText;
             caretUL.appendChild(caretLiShow);
             let showInFinderDocument = document.getElementById('download-show-in-folder');
             showInFinderDocument.addEventListener('click', () => {
diff --git a/js/windowMgr.js b/js/windowMgr.js
index 6aa36bd0..1f98f222 100644
--- a/js/windowMgr.js
+++ b/js/windowMgr.js
@@ -1008,6 +1008,12 @@ function setLocale(browserWindow, opts) {
         }
 
         localeContent.contextMenu = i18n.getMessageFor('ContextMenu');
+
+        localeContent.downloadManager = i18n.getMessageFor('DownloadManager');
+        if (isMac) {
+            localeContent.downloadManager['Show in Folder'] = localeContent.downloadManager['Reveal in Finder'];
+        }
+
         browserWindow.webContents.send('locale-changed', localeContent);
     }
 
diff --git a/locale/en-US.json b/locale/en-US.json
index fa617005..246316de 100644
--- a/locale/en-US.json
+++ b/locale/en-US.json
@@ -32,6 +32,11 @@
     "Reload": "Reload",
     "Search with Google": "Search with Google"
   },
+  "DownloadManager": {
+    "Show in Folder": "Show in Folder",
+    "Reveal in Finder": "Reveal in Finder",
+    "Open": "Open"
+  },
   "Copy": "Copy",
   "Custom": "Custom",
   "Cut": "Cut",
diff --git a/locale/en.json b/locale/en.json
index ec1bbc7c..4569b4a0 100644
--- a/locale/en.json
+++ b/locale/en.json
@@ -32,6 +32,11 @@
     "Reload": "Reload",
     "Search with Google": "Search with Google"
   },
+  "DownloadManager": {
+    "Show in Folder": "Show in Folder",
+    "Reveal in Finder": "Reveal in Finder",
+    "Open": "Open"
+  },
   "Copy": "Copy",
   "Custom": "Custom",
   "Cut": "Cut",
diff --git a/locale/ja-JP.json b/locale/ja-JP.json
index 2361fce6..00f4e57a 100644
--- a/locale/ja-JP.json
+++ b/locale/ja-JP.json
@@ -32,6 +32,11 @@
     "Reload": "リロード",
     "Search with Google": "Googleで検索"
   },
+  "DownloadManager": {
+    "Show in Folder": "フォルダで見て",
+    "Reveal in Finder": "Finderで明らかにする",
+    "Open": "開いた"
+  },
   "Copy": "コピー",
   "Custom": "カスタム",
   "Cut": "切り取り",
diff --git a/locale/ja.json b/locale/ja.json
index 06a956da..cf69c676 100644
--- a/locale/ja.json
+++ b/locale/ja.json
@@ -32,6 +32,11 @@
     "Reload": "リロード",
     "Search with Google": "Googleで検索"
   },
+  "DownloadManager": {
+    "Show in Folder": "フォルダで見て",
+    "Reveal in Finder": "Finderで明らかにする",
+    "Open": "開いた"
+  },
   "Copy": "コピー",
   "Custom": "カスタム",
   "Cut": "切り取り",