Merge pull request #239 from VishwasShashidhar/electron-214

Electron 214: Set "Minimize on Close" to true by default during installation
This commit is contained in:
Vikas Shashidhar 2017-11-20 12:24:15 +05:30 committed by GitHub
commit 775b734b17
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 20 additions and 19 deletions

View File

@ -1,6 +1,6 @@
{ {
"url": "https://foundation-dev.symphony.com", "url": "https://foundation-dev.symphony.com",
"minimizeOnClose" : false, "minimizeOnClose" : true,
"launchOnStartup" : true, "launchOnStartup" : true,
"alwaysOnTop" : false, "alwaysOnTop" : false,
"notificationSettings": { "notificationSettings": {

View File

@ -3,7 +3,7 @@
<plist version="1.0"> <plist version="1.0">
<dict> <dict>
<key>BuildMachineOSBuild</key> <key>BuildMachineOSBuild</key>
<string>17A405</string> <string>17B48</string>
<key>CFBundleDevelopmentRegion</key> <key>CFBundleDevelopmentRegion</key>
<string>en</string> <string>en</string>
<key>CFBundleExecutable</key> <key>CFBundleExecutable</key>
@ -27,17 +27,17 @@
<key>DTCompiler</key> <key>DTCompiler</key>
<string>com.apple.compilers.llvm.clang.1_0</string> <string>com.apple.compilers.llvm.clang.1_0</string>
<key>DTPlatformBuild</key> <key>DTPlatformBuild</key>
<string>9A1004</string> <string>9B55</string>
<key>DTPlatformVersion</key> <key>DTPlatformVersion</key>
<string>GM</string> <string>GM</string>
<key>DTSDKBuild</key> <key>DTSDKBuild</key>
<string>17A360</string> <string>17B41</string>
<key>DTSDKName</key> <key>DTSDKName</key>
<string>macosx10.13</string> <string>macosx10.13</string>
<key>DTXcode</key> <key>DTXcode</key>
<string>0901</string> <string>0910</string>
<key>DTXcodeBuild</key> <key>DTXcodeBuild</key>
<string>9A1004</string> <string>9B55</string>
<key>InstallerSectionTitle</key> <key>InstallerSectionTitle</key>
<string>Pod Settings</string> <string>Pod Settings</string>
<key>NSHumanReadableCopyright</key> <key>NSHumanReadableCopyright</key>

View File

@ -6,7 +6,7 @@
<dict> <dict>
<key>Resources/Base.lproj/MyInstallerPane.nib</key> <key>Resources/Base.lproj/MyInstallerPane.nib</key>
<data> <data>
TF/AqkGdS25ttnHMS1l76ES81/w= GZWN47BPj6b6mD6MnSVH/Qn0m3s=
</data> </data>
<key>Resources/InstallerSections.plist</key> <key>Resources/InstallerSections.plist</key>
<data> <data>
@ -37,11 +37,11 @@
<dict> <dict>
<key>hash</key> <key>hash</key>
<data> <data>
TF/AqkGdS25ttnHMS1l76ES81/w= GZWN47BPj6b6mD6MnSVH/Qn0m3s=
</data> </data>
<key>hash2</key> <key>hash2</key>
<data> <data>
gxXMI4SoTYE7jYkP5QJ7i804TUXR4x8LGSh99n9qers= cJ/kr1HEozYL0YeZriWDtnOL1NEd22vHzH5WGp1T3hk=
</data> </data>
</dict> </dict>
<key>Resources/InstallerSections.plist</key> <key>Resources/InstallerSections.plist</key>

View File

@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="13196" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct"> <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="13529" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
<dependencies> <dependencies>
<deployment identifier="macosx"/> <deployment identifier="macosx"/>
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="13196"/> <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="13529"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/> <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies> </dependencies>
<objects> <objects>
@ -59,7 +59,7 @@
<button fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="XPe-yO-v9Y"> <button fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="XPe-yO-v9Y">
<rect key="frame" x="194" y="85" width="22" height="18"/> <rect key="frame" x="194" y="85" width="22" height="18"/>
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/> <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
<buttonCell key="cell" type="check" bezelStyle="regularSquare" imagePosition="left" inset="2" id="uvu-EE-3sp"> <buttonCell key="cell" type="check" bezelStyle="regularSquare" imagePosition="left" state="on" inset="2" id="uvu-EE-3sp">
<behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/> <behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/>
<font key="font" metaFont="system"/> <font key="font" metaFont="system"/>
</buttonCell> </buttonCell>

View File

@ -48,23 +48,23 @@
NSString *podUrl = [_podUrlTextBox stringValue]; NSString *podUrl = [_podUrlTextBox stringValue];
// By default, set autoLaunchOnStart to true // By default, set autoLaunchOnStart and minimizeOnClose to true
NSString *autoLaunchOnStart = @"true"; NSString *autoLaunchOnStart = @"true";
NSString *minimizeOnClose = @"true";
// If the checkbox is changed, set the auto launch value accordingly // If the checkbox is changed, set the auto launch value accordingly
if ([_autoLaunchCheckBox state] == 0) { if ([_autoLaunchCheckBox state] == 0) {
autoLaunchOnStart = @"false"; autoLaunchOnStart = @"false";
} }
// By default, set minimizeOnClose and alwaysOnTop to false
NSString *minimizeOnClose = @"false";
NSString *alwaysOnTop = @"false\n";
// If the checkbox is changed, set the minimize on close value accordingly // If the checkbox is changed, set the minimize on close value accordingly
if ([_minimizeOnCloseCheckBox state] == 1) { if ([_minimizeOnCloseCheckBox state] == 0) {
minimizeOnClose = @"true"; minimizeOnClose = @"false";
} }
// By default, set alwaysOnTop to false
NSString *alwaysOnTop = @"false\n";
// If the checkbox is changed, set the always on top value accordingly // If the checkbox is changed, set the always on top value accordingly
if ([_alwaysOnTopCheckBox state] == 1) { if ([_alwaysOnTopCheckBox state] == 1) {
alwaysOnTop = @"true\n"; alwaysOnTop = @"true\n";

View File

@ -24,6 +24,7 @@
<ROW Property="CTRLS" Value="2"/> <ROW Property="CTRLS" Value="2"/>
<ROW Property="DialogBitmap" Value="dialog" MultiBuildValue="DefaultBuild:Tabloid.jpg" Type="1" MsiKey="DialogBitmap"/> <ROW Property="DialogBitmap" Value="dialog" MultiBuildValue="DefaultBuild:Tabloid.jpg" Type="1" MsiKey="DialogBitmap"/>
<ROW Property="INVALID_POD_URL" Value="valid" Type="4"/> <ROW Property="INVALID_POD_URL" Value="valid" Type="4"/>
<ROW Property="MINIMIZE_ON_CLOSE" Value="true"/>
<ROW Property="MINIMIZE_ON_CLOSE_LABEL" Value="false" Type="4"/> <ROW Property="MINIMIZE_ON_CLOSE_LABEL" Value="false" Type="4"/>
<ROW Property="Manufacturer" Value="Symphony"/> <ROW Property="Manufacturer" Value="Symphony"/>
<ROW Property="POD_URL" Value="https://corporate.symphony.com" Type="4"/> <ROW Property="POD_URL" Value="https://corporate.symphony.com" Type="4"/>