From 53ea47b7ee81d21f0d744a3175cd5536d3f0d34c Mon Sep 17 00:00:00 2001 From: Johan Kwarnmark Date: Tue, 26 May 2020 15:01:26 +0200 Subject: [PATCH 1/2] sda-1971 make the pop-out full screen enable --- src/app/child-window-handler.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/child-window-handler.ts b/src/app/child-window-handler.ts index 2061c032..69aa0c01 100644 --- a/src/app/child-window-handler.ts +++ b/src/app/child-window-handler.ts @@ -159,6 +159,7 @@ export const handleChildWindow = (webContents: WebContents): void => { // Event needed to hide native menu bar childWebContents.once('did-start-loading', () => { const browserWin = BrowserWindow.fromWebContents(childWebContents) as ICustomBrowserWindow; + browserWin.setFullScreenable(true); browserWin.origin = windowHandler.url; if (isWindowsOS && browserWin && !browserWin.isDestroyed()) { browserWin.setMenuBarVisibility(false); From 354867b764f7284f5060d199b09abd474a8f8eea Mon Sep 17 00:00:00 2001 From: Johan Kwarnmark Date: Wed, 27 May 2020 09:15:37 +0200 Subject: [PATCH 2/2] Add mock for setFullScreenable --- spec/childWindowHandle.spec.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/childWindowHandle.spec.ts b/spec/childWindowHandle.spec.ts index 2d2bd962..0c7a9965 100644 --- a/spec/childWindowHandle.spec.ts +++ b/spec/childWindowHandle.spec.ts @@ -15,6 +15,7 @@ const getMainWindow = { isAlwaysOnTop: jest.fn(() => true), setMenuBarVisibility: jest.fn(), setAlwaysOnTop: jest.fn(), + setFullScreenable: jest.fn(), }; jest.mock('../src/common/env', () => {