revert the icons and remove icon-gen

electron-builder.yml

@@ -33,11 +33,11 @@ extraFiles:
 # Mac OS configuration
 mac:
   category: 'public.app-category.business'
-  icon: 'build/icons/mac/icon.icns'
+  icon: 'images/icon.icns'
 
 # Windows configuration
 win:
-  icon: 'build/icons/win/icon.ico'
+  icon: 'images/icon.ico'
   target:
     - 'squirrel'
 
@@ -49,4 +49,4 @@ linux:
   target:
     - 'deb'
     - 'rpm'
-  icon: 'build/icons/png'
+  icon: 'images/linux'

installer/win/Symphony-x64.aip

@@ -640,7 +640,7 @@
     <ROW Dialog="UrlValidationDlg" HCentering="50" VCentering="50" Width="370" Height="270" Attributes="3" Title="[ProductName] [Setup]" Control_Default="Next" Control_Cancel="Cancel"/>
   </COMPONENT>
   <COMPONENT cid="caphyon.advinst.msicomp.MsiIconsComponent">
-    <ROW Name="icon.exe" SourcePath="..\..\build\icons\win\icon.ico" Index="0"/>
+    <ROW Name="icon.exe" SourcePath="..\..\images\icon.ico" Index="0"/>
   </COMPONENT>
   <COMPONENT cid="caphyon.advinst.msicomp.MsiInstExSeqComponent">
     <ROW Action="AI_DOWNGRADE" Condition="AI_NEWERPRODUCTFOUND AND (UILevel &lt;&gt; 5)" Sequence="210"/>

installer/win/Symphony-x86.aip

@@ -624,7 +624,7 @@
     <ROW Dialog="UrlValidationDlg" HCentering="50" VCentering="50" Width="370" Height="270" Attributes="3" Title="[ProductName] [Setup]" Control_Default="Next" Control_Cancel="Cancel"/>
   </COMPONENT>
   <COMPONENT cid="caphyon.advinst.msicomp.MsiIconsComponent">
-    <ROW Name="icon.exe" SourcePath="..\..\build\icons\win\icon.ico" Index="0"/>
+    <ROW Name="icon.exe" SourcePath="..\..\images\icon.ico" Index="0"/>
   </COMPONENT>
   <COMPONENT cid="caphyon.advinst.msicomp.MsiInstExSeqComponent">
     <ROW Action="AI_DOWNGRADE" Condition="AI_NEWERPRODUCTFOUND AND (UILevel &lt;&gt; 5)" Sequence="210"/>

package.json

@@ -3,7 +3,7 @@
   "productName": "Symphony",
   "version": "5.0.0",
   "clientVersion": "2.0.1",
-  "buildNumber": "",
+  "buildNumber": "0",
   "searchAPIVersion": "1.55.3",
   "description": "Symphony desktop app (Foundation ODP)",
   "author": "Symphony OSS <help@finos.org>",
@@ -15,17 +15,16 @@
     "dev": "npm run prebuild && cross-env ELECTRON_DEV=true electron .",
     "demo-win": "npm run prebuild && cross-env ELECTRON_DEV=true electron . --url=file:///src/demo/index.html",
     "demo-mac": "npm run prebuild && cross-env ELECTRON_DEV=true electron . --url=file://$(pwd)/src/demo/index.html",
-    "icon-gen": "electron-icon-maker --input=images/icon_1024.png --output=./build",
     "lint": "tslint --project tsconfig.json",
-    "packed-linux": "npm run prebuild && npm run test && npm run icon-gen && build --linux",
+    "packed-linux": "npm run prebuild && npm run test && build --linux",
     "packed-mac": "npm run unpacked-mac && packagesbuild -v installer/mac/symphony-mac-packager.pkgproj",
     "prebuild": "npm run compile && npm run rebuild && npm run browserify-preload",
     "rebuild": "electron-rebuild -f",
     "start": "npm run compile && npm run browserify-preload && cross-env ELECTRON_DEV=true electron .",
     "test": "npm run lint && cross-env ELECTRON_QA=true jest --config jest-config.json --runInBand --detectOpenHandles",
-    "unpacked-mac": "npm run prebuild && npm run test && npm run icon-gen && build --mac --dir",
-    "unpacked-win": "npm run prebuild && npm run test && npm run icon-gen && build --win --x64 --dir",
-    "unpacked-win-x86": "npm run prebuild && npm run test && npm run icon-gen && build --win --ia32 --dir"
+    "unpacked-mac": "npm run prebuild && npm run test && build --mac --dir",
+    "unpacked-win": "npm run prebuild && npm run test && build --win --x64 --dir",
+    "unpacked-win-x86": "npm run prebuild && npm run test && build --win --ia32 --dir"
   },
   "repository": {
     "type": "git",