ELECTRON-1100 - Add safety check for toggle developer tools (#622)

This commit is contained in:
Kiran Niranjan
2019-03-29 09:55:54 +05:30
committed by Vishwas Shashidhar
parent ef392b2c60
commit 9418d8103b

View File

@@ -196,16 +196,18 @@ function getTemplate(app) {
accelerator: isMac ? 'Alt+Command+I' : 'Ctrl+Shift+I',
click(item, focusedWindow) {
let devToolsEnabled = readConfigFromFile('devToolsEnabled');
if (focusedWindow && devToolsEnabled) {
focusedWindow.webContents.toggleDevTools();
} else {
log.send(logLevels.INFO, `dev tools disabled for ${focusedWindow.winName} window`);
electron.dialog.showMessageBox(focusedWindow, {
type: 'warning',
buttons: ['Ok'],
title: i18n.getMessageFor('Dev Tools disabled'),
message: i18n.getMessageFor('Dev Tools has been disabled! Please contact your system administrator to enable it!'),
});
if (focusedWindow && !focusedWindow.isDestroyed()) {
if (devToolsEnabled) {
focusedWindow.webContents.toggleDevTools();
} else {
log.send(logLevels.INFO, `dev tools disabled for ${focusedWindow.winName} window`);
electron.dialog.showMessageBox(focusedWindow, {
type: 'warning',
buttons: ['Ok'],
title: i18n.getMessageFor('Dev Tools disabled'),
message: i18n.getMessageFor('Dev Tools has been disabled! Please contact your system administrator to enable it!'),
});
}
}
}
},