if/SymphonyElectron
1
0 Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2026-10-26 06:30:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat: SDA-2315: add chrome flag for network in process"

Browse Source
This commit is contained in:
Vishwas Shashidhar authored and GitHub committed 2020-08-12 18:51:19 +05:30
1 parent 10dc7d8fd3
commit 9c4adee1cf
2 files changed
+8 -9
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

spec/chromeFlags.spec.ts
+8 -8
View File
@@ -98,8 +98,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => {
@@ -110,8 +110,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(9, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(10);
expect(spy).nthCalledWith(8, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(9);
});
it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => {
@@ -132,8 +132,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => {
@@ -154,8 +154,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
describe('`isDevEnv`', () => {
src/app/chrome-flags.ts
-1
View File
@@ -26,7 +26,6 @@ export const setChromeFlags = () => {
'disable-gpu': flagsConfig.disableGpu || null,
'disable-gpu-compositing': flagsConfig.disableGpu || null,
'enable-experimental-web-platform-features': 'true',
'enable-features': 'NetworkService,NetworkServiceInProcess',
};
if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) {
configFlags['disable-renderer-backgrounding'] = 'true';