if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat: SDA-2315: add chrome flag for network in process"

Browse Source
This commit is contained in:
Vishwas Shashidhar 2020-08-12 18:51:19 +05:30 committed by GitHub
parent 10dc7d8fd3
commit 9c4adee1cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spec/chromeFlags.spec.ts
View File

@ -98,8 +98,8 @@ describe('chrome flags', () => {
}); });
const spy = jest.spyOn(app.commandLine, 'appendSwitch'); const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags(); setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7); expect(spy).not.nthCalledWith(6);
}); });
it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => { it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => {
@ -110,8 +110,8 @@ describe('chrome flags', () => {
}); });
const spy = jest.spyOn(app.commandLine, 'appendSwitch'); const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags(); setChromeFlags();
expect(spy).nthCalledWith(9, 'disable-renderer-backgrounding', 'true'); expect(spy).nthCalledWith(8, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(10); expect(spy).not.nthCalledWith(9);
}); });
it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => { it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => {
@ -132,8 +132,8 @@ describe('chrome flags', () => {
}); });
const spy = jest.spyOn(app.commandLine, 'appendSwitch'); const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags(); setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7); expect(spy).not.nthCalledWith(6);
}); });
it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => { it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => {
@ -154,8 +154,8 @@ describe('chrome flags', () => {
}); });
const spy = jest.spyOn(app.commandLine, 'appendSwitch'); const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags(); setChromeFlags();
expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(7); expect(spy).not.nthCalledWith(6);
}); });
describe('`isDevEnv`', () => { describe('`isDevEnv`', () => {

1
src/app/chrome-flags.ts
View File

@ -26,7 +26,6 @@ export const setChromeFlags = () => {
'disable-gpu': flagsConfig.disableGpu || null, 'disable-gpu': flagsConfig.disableGpu || null,
'disable-gpu-compositing': flagsConfig.disableGpu || null, 'disable-gpu-compositing': flagsConfig.disableGpu || null,
'enable-experimental-web-platform-features': 'true', 'enable-experimental-web-platform-features': 'true',
'enable-features': 'NetworkService,NetworkServiceInProcess',
}; };
if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) { if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) {
configFlags['disable-renderer-backgrounding'] = 'true'; configFlags['disable-renderer-backgrounding'] = 'true';