From a06e17a12a20fb12cdbab6c74cc30b0a5019c597 Mon Sep 17 00:00:00 2001
From: Kiran Niranjan <kiran.niranjan@symphony.com>
Date: Tue, 27 Feb 2018 09:24:40 +0530
Subject: [PATCH] Electron-308 Removed messages from constants and hardcoded it
 as per PR review

---
 tests/spectron/alwaysOnTop.spectron.js          | 4 ++--
 tests/spectron/bringToFront.spectron.js         | 2 +-
 tests/spectron/clipboard.spectron.js            | 2 +-
 tests/spectron/close.spectron.js                | 2 +-
 tests/spectron/full-screen.spectron.js          | 4 ++--
 tests/spectron/minimize-on-close.spectron.js    | 4 ++--
 tests/spectron/notificationPosition.spectron.js | 2 +-
 tests/spectron/spectronConstants.js             | 4 ----
 tests/spectron/spellChecker.spectron.js         | 2 +-
 tests/spectron/zoom-in-zoom-out.spectron.js     | 4 ++--
 10 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/tests/spectron/alwaysOnTop.spectron.js b/tests/spectron/alwaysOnTop.spectron.js
index c01858e0..18c717ca 100644
--- a/tests/spectron/alwaysOnTop.spectron.js
+++ b/tests/spectron/alwaysOnTop.spectron.js
@@ -22,12 +22,12 @@ describe('Tests for Always on top', () => {
                     configPath = config;
                     done();
                 }).catch((err) => {
-                    console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err);
+                    console.error(`Unable to get user config path error: ${err}`);
                     expect(err).toBeNull();
                     done();
                 });
             }).catch((err) => {
-                console.error(constants.UNABLE_TO_START_APPLICATION, err);
+                console.error(`Unable to start application error: ${err}`);
                 expect(err).toBeNull();
                 done();
             });
diff --git a/tests/spectron/bringToFront.spectron.js b/tests/spectron/bringToFront.spectron.js
index 24d8a461..609d48c4 100644
--- a/tests/spectron/bringToFront.spectron.js
+++ b/tests/spectron/bringToFront.spectron.js
@@ -13,7 +13,7 @@ describe('Tests for Bring to front', () => {
             app = startedApp;
             done();
         }).catch((err) => {
-            console.error(constants.UNABLE_TO_START_APPLICATION, err);
+            console.error(`Unable to start application error: ${err}`);
             expect(err).toBeNull();
             done();
         });
diff --git a/tests/spectron/clipboard.spectron.js b/tests/spectron/clipboard.spectron.js
index 4a8d9619..5458c136 100644
--- a/tests/spectron/clipboard.spectron.js
+++ b/tests/spectron/clipboard.spectron.js
@@ -14,7 +14,7 @@ describe('Tests for clipboard', () => {
             app = startedApp;
             done();
         }).catch((err) => {
-            console.error(constants.UNABLE_TO_START_APPLICATION, err);
+            console.error(`Unable to start application error: ${err}`);
             expect(err).toBeNull();
             done();
         });
diff --git a/tests/spectron/close.spectron.js b/tests/spectron/close.spectron.js
index a5d95c03..67107b06 100644
--- a/tests/spectron/close.spectron.js
+++ b/tests/spectron/close.spectron.js
@@ -13,7 +13,7 @@ describe('Tests for Close', () => {
             app = startedApp;
             done();
         }).catch((err) => {
-            console.error(constants.UNABLE_TO_START_APPLICATION, err);
+            console.error(`Unable to start application error: ${err}`);
             expect(err).toBeNull();
             done();
         });
diff --git a/tests/spectron/full-screen.spectron.js b/tests/spectron/full-screen.spectron.js
index e1f2a001..ec75db6e 100644
--- a/tests/spectron/full-screen.spectron.js
+++ b/tests/spectron/full-screen.spectron.js
@@ -21,12 +21,12 @@ describe('Tests for Full screen', () => {
                     configPath = config;
                     done();
                 }).catch((err) => {
-                    console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err);
+                    console.error(`Unable to get user config path error: ${err}`);
                     expect(err).toBeNull();
                     done();
                 });
             }).catch((err) => {
-                console.error(constants.UNABLE_TO_START_APPLICATION, err);
+                console.error(`Unable to start application error: ${err}`);
                 expect(err).toBeNull();
                 done();
             });
diff --git a/tests/spectron/minimize-on-close.spectron.js b/tests/spectron/minimize-on-close.spectron.js
index 7af094ff..fb955388 100644
--- a/tests/spectron/minimize-on-close.spectron.js
+++ b/tests/spectron/minimize-on-close.spectron.js
@@ -21,12 +21,12 @@ describe('Tests for Minimize on Close', () => {
                     configPath = config;
                     done();
                 }).catch((err) => {
-                    console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err);
+                    console.error(`Unable to get user config path error: ${err}`);
                     expect(err).toBeNull();
                     done();
                 });
             }).catch((err) => {
-                console.error(constants.UNABLE_TO_START_APPLICATION, err);
+                console.error(`Unable to start application error: ${err}`);
                 expect(err).toBeNull();
                 done();
             });
diff --git a/tests/spectron/notificationPosition.spectron.js b/tests/spectron/notificationPosition.spectron.js
index d6940fc1..d20582ce 100644
--- a/tests/spectron/notificationPosition.spectron.js
+++ b/tests/spectron/notificationPosition.spectron.js
@@ -15,7 +15,7 @@ describe('Tests for Notification position', () => {
             app = startedApp;
             done();
         }).catch((err) => {
-            console.error(constants.UNABLE_TO_START_APPLICATION, err);
+            console.error(`Unable to start application error: ${err}`);
             expect(err).toBeNull();
             done();
         });
diff --git a/tests/spectron/spectronConstants.js b/tests/spectron/spectronConstants.js
index c29796f8..458def36 100644
--- a/tests/spectron/spectronConstants.js
+++ b/tests/spectron/spectronConstants.js
@@ -7,8 +7,4 @@ module.exports = {
 
     SEARCH_LIBRARY_PATH_MAC: "node_modules/electron/dist/Electron.app/Contents/library",
     SEARCH_LIBRARY_PATH_WIN: "node_modules/electron/dist/library",
-
-
-    UNABLE_TO_START_APPLICATION: "Unable to start application error: ",
-    UNABLE_TO_GET_USER_CONFIG_PATH: "Unable to get user config path error: "
 };
\ No newline at end of file
diff --git a/tests/spectron/spellChecker.spectron.js b/tests/spectron/spellChecker.spectron.js
index bc93458b..766cfeb2 100644
--- a/tests/spectron/spellChecker.spectron.js
+++ b/tests/spectron/spellChecker.spectron.js
@@ -19,7 +19,7 @@ describe('Tests for spellChecker', () => {
                 app = startedApp;
                 done();
             }).catch((err) => {
-                console.error(constants.UNABLE_TO_START_APPLICATION, err);
+                console.error(`Unable to start application error: ${err}`);
                 expect(err).toBeNull();
                 done();
             });
diff --git a/tests/spectron/zoom-in-zoom-out.spectron.js b/tests/spectron/zoom-in-zoom-out.spectron.js
index 73e2562e..3ddf3467 100644
--- a/tests/spectron/zoom-in-zoom-out.spectron.js
+++ b/tests/spectron/zoom-in-zoom-out.spectron.js
@@ -22,12 +22,12 @@ describe('Tests for Zoom in and Zoom out', () => {
                     configPath = config;
                     done();
                 }).catch((err) => {
-                    console.error(constants.UNABLE_TO_GET_USER_CONFIG_PATH, err);
+                    console.error(`Unable to get user config path error: ${err}`);
                     expect(err).toBeNull();
                     done();
                 });
             }).catch((err) => {
-                console.error(constants.UNABLE_TO_START_APPLICATION, err);
+                console.error(`Unable to start application error: ${err}`);
                 expect(err).toBeNull();
                 done();
             });