if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

ELECTRON-1138: support opening email composition in new window (#602)

Browse Source 
* bump up version number

* ELECTRON-1138: support opening email composition in new window

Currently, due to security reasons, we don't open any url which is not the same as the main window url in a new window, instead, we open it in a new tab of the system default browser.

However, this impacts the email app as we'll need new window to be opened to compose an email. This commit fixes that issue by checking if we need to open a sub-domain of the pod url domain.
This commit is contained in:
Vishwas Shashidhar
2019-03-19 18:00:52 +05:30
committed by GitHub
parent 01628e453f
commit a074126537
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/windowMgr.js
View File

@@ -466,7 +466,7 @@ function doCreateMainWindow(initialUrl, initialBounds, isCustomTitleBar) {
// only allow window.open to succeed is if coming from same host, // only allow window.open to succeed is if coming from same host,
// otherwise open in default browser. // otherwise open in default browser.
if ((newWinHost === mainWinHost || newWinUrl === emptyUrlString) && dispositionWhitelist.includes(disposition)) { if ((newWinHost === mainWinHost || newWinUrl === emptyUrlString || (newWinHost.indexOf(mainWinHost) !== -1 && frameName !== "")) && dispositionWhitelist.includes(disposition)) {
// handle: window.open // handle: window.open
if (!frameName) { if (!frameName) {

2
package.json
View File

@@ -1,7 +1,7 @@
{ {
"name": "Symphony", "name": "Symphony",
"productName": "Symphony", "productName": "Symphony",
"version": "4.4.2", "version": "4.5.0",
"clientVersion": "1.54", "clientVersion": "1.54",
"buildNumber": "0", "buildNumber": "0",
"description": "Symphony desktop app (Foundation ODP)", "description": "Symphony desktop app (Foundation ODP)",