From a20c1964907f71c493adb1ddb36247958bf13d81 Mon Sep 17 00:00:00 2001
From: Kiran Niranjan <kiran.niranjan@symphony.com>
Date: Fri, 1 May 2020 10:33:56 +0530
Subject: [PATCH] fix: SDA-2010 (Mac and Linux build scripts) (#983)

* Linux: Install new packages to support latest SDA dependency

* Fix build-linux scripts

An issue with if condition and install gulp-cli deps

* Fix build-mac scripts

An issue with if condition and install gulp-cli deps
---
 scripts/build-linux.sh | 4 ++--
 scripts/build-mac.sh   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/build-linux.sh b/scripts/build-linux.sh
index cd75c5b4..e366aa7b 100644
--- a/scripts/build-linux.sh
+++ b/scripts/build-linux.sh
@@ -36,7 +36,7 @@ fi
 
 if ! [ -x "$(command -v gulp)" ]; then
   echo 'Gulp does not exist! Installing it!' >&2
-  npm install -g gulp
+  npm install -g gulp gulp-cli
 fi
 
 if ! [ -x "$(command -v snyk)" ]; then
@@ -81,7 +81,7 @@ sed -i -e "s/\"buildNumber\"[[:space:]]*\:[[:space:]]*\".*\"/\"buildNumber\":\"
 echo "Setting package version in pre install script to ${PKG_VERSION}"
 sed -i -e "s/CURRENT_VERSION=APP_VERSION/CURRENT_VERSION=${PKG_VERSION}/g" ./installer/mac/preinstall.sh
 
-if [ -z "$EXPIRY_PERIOD" ]; then
+if [ "$EXPIRY_PERIOD" == "0" ] || [ "$EXPIRY_PERIOD" == 0 ]; then
   echo 'Expiry period not set, so, not creating expiry for the build'
 else
   gulp setExpiry --period ${EXPIRY_PERIOD}
diff --git a/scripts/build-mac.sh b/scripts/build-mac.sh
index fb8d882c..7bff0022 100755
--- a/scripts/build-mac.sh
+++ b/scripts/build-mac.sh
@@ -37,7 +37,7 @@ fi
 
 if ! [ -x "$(command -v gulp)" ]; then
   echo 'Gulp does not exist! Installing it!' >&2
-  npm install -g gulp
+  npm install -g gulp gulp-cli
 fi
 
 if ! [ -x "$(command -v snyk)" ]; then
@@ -98,7 +98,7 @@ echo "Setting package version in pre install script to ${PKG_VERSION}"
 sed -i -e "s/CURRENT_VERSION=APP_VERSION/CURRENT_VERSION=${PKG_VERSION}/g" ./installer/mac/preinstall.sh
 
 # Set expiry period for TTL builds
-if [ -z "$EXPIRY_PERIOD" ]; then
+if [ "$EXPIRY_PERIOD" == "0" ] || [ "$EXPIRY_PERIOD" == 0 ]; then
   echo 'Expiry period not set, so, not creating expiry for the build'
 else
   gulp setExpiry --period ${EXPIRY_PERIOD}