if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-20 11:48:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

electron-135: fixes as per PR comments to avoid leakages

Browse Source
This commit is contained in:
Vishwas Shashidhar 2017-10-06 23:44:16 +05:30
parent 9dfbdaa1bb
commit a291846001
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/windowMgr.js
View File

@ -347,10 +347,10 @@ function doCreateMainWindow(initialUrl, initialBounds) {
electron.dialog.showMessageBox(options, function (index) {
if (index === 0) {
mainWindow.reload();
browserWin.reload();
}
else {
mainWindow.close();
browserWin.close();
}
});
});
@ -363,6 +363,12 @@ function doCreateMainWindow(initialUrl, initialBounds) {
openUrlInDefaultBrowser(childWinUrl);
});
// Clear up the browser window once the window is closed
// to avoid leakage
browserWin.on('closed', () => {
browserWin = null;
});
addWindowKey(newWinKey, browserWin);
// Method that sends bound changes as soon