if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2024-11-21 16:38:41 -06:00
Code Issues Packages Projects Releases Wiki Activity

SDA-3377 Added support for chromeFlags install param

Browse Source
This commit is contained in:
Mattias Gustavsson 2021-10-14 09:11:02 +02:00
parent a89310c58e
commit a916733619
4 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
config/Symphony.config
View File

@ -35,5 +35,6 @@
"openExternal": true
},
"autoLaunchPath": "",
"userDataPath": ""
"userDataPath": "",
"chromeFlags": ""
}

4
installer/win/WixSharpInstaller/Symphony.cs
View File

@ -213,6 +213,7 @@ class Script
new PublicProperty("POINTER_LOCK", "true"),
new PublicProperty("USER_DATA_PATH", ""),
new PublicProperty("OVERRIDE_USER_AGENT", "false"),
new PublicProperty("CHROME_FLAGS", ""),
new Property("MSIINSTALLPERUSER", "1"),
new Property("PROGRAMSFOLDER", System.Environment.ExpandEnvironmentVariables(@"%PROGRAMFILES%"))
};
@ -240,7 +241,7 @@ class Script
new ElevatedManagedAction(CustomActions.UpdateConfig, Return.check, When.After, Step.InstallFiles, Condition.NOT_BeingRemoved )
{
// The UpdateConfig action needs the built-in property INSTALLDIR as well as most of the custom properties
UsesProperties = "INSTALLDIR,POD_URL,CONTEXT_ORIGIN_URL,MINIMIZE_ON_CLOSE,ALWAYS_ON_TOP,AUTO_START,BRING_TO_FRONT,MEDIA,LOCATION,NOTIFICATIONS,MIDI_SYSEX,POINTER_LOCK,FULL_SCREEN,OPEN_EXTERNAL,CUSTOM_TITLE_BAR,DEV_TOOLS_ENABLED,AUTO_LAUNCH_PATH,USER_DATA_PATH,OVERRIDE_USER_AGENT"
UsesProperties = "INSTALLDIR,POD_URL,CONTEXT_ORIGIN_URL,MINIMIZE_ON_CLOSE,ALWAYS_ON_TOP,AUTO_START,BRING_TO_FRONT,MEDIA,LOCATION,NOTIFICATIONS,MIDI_SYSEX,POINTER_LOCK,FULL_SCREEN,OPEN_EXTERNAL,CUSTOM_TITLE_BAR,DEV_TOOLS_ENABLED,AUTO_LAUNCH_PATH,USER_DATA_PATH,OVERRIDE_USER_AGENT,CHROME_FLAGS"
},
// CleanRegistry
@ -401,6 +402,7 @@ public class CustomActions
data = ReplaceProperty(data, "isCustomTitleBar", session.Property("CUSTOM_TITLE_BAR"));
data = ReplaceProperty(data, "autoLaunchPath", FixPathFormat(session.Property("AUTO_LAUNCH_PATH")));
data = ReplaceProperty(data, "userDataPath", FixPathFormat(session.Property("USER_DATA_PATH")));
data = ReplaceProperty(data, "chromeFlags", session.Property("CHROME_FLAGS"));
data = ReplaceBooleanProperty(data, "pointerLock", session.Property("POINTER_LOCK"));
data = ReplaceBooleanProperty(data, "openExternal", session.Property("OPEN_EXTERNAL"));
data = ReplaceBooleanProperty(data, "notifications", session.Property("NOTIFICATIONS"));

18
installer/win/install_instructions_win.md
View File

@ -512,4 +512,20 @@ Expected values:
or
msiexec /i Symphony.msi
msiexec /i Symphony.msi
-------------------------------------------------------------------
### CHROME_FLAGS
Expected values:
* A single string containing all flags to be passed to chrome
(default is "" )
#### Example
msiexec /i Symphony.msi CHROME_FLAGS="--debug --debug2 --debug3"

4
src/app/chrome-flags.ts
View File

@ -92,6 +92,10 @@ export const setChromeFlags = () => {
);
}
});
const { chromeFlags } = config.getConfigFields(['chromeFlags']) as any;
app.commandLine.appendArgument(chromeFlags);
logger.info(`chrome-flags: Appended chrome command line with ${chromeFlags}`);
};
/**