From 9c4adee1cf0984f868f4b838597cb692ae363ed6 Mon Sep 17 00:00:00 2001 From: Vishwas Shashidhar Date: Wed, 12 Aug 2020 18:51:19 +0530 Subject: [PATCH] Revert "feat: SDA-2315: add chrome flag for network in process" --- spec/chromeFlags.spec.ts | 16 ++++++++-------- src/app/chrome-flags.ts | 1 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/spec/chromeFlags.spec.ts b/spec/chromeFlags.spec.ts index f77a71b6..6cfdc0f8 100644 --- a/spec/chromeFlags.spec.ts +++ b/spec/chromeFlags.spec.ts @@ -98,8 +98,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(7); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => { @@ -110,8 +110,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(9, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(10); + expect(spy).nthCalledWith(8, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(9); }); it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => { @@ -132,8 +132,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(7); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => { @@ -154,8 +154,8 @@ describe('chrome flags', () => { }); const spy = jest.spyOn(app.commandLine, 'appendSwitch'); setChromeFlags(); - expect(spy).nthCalledWith(6, 'disable-renderer-backgrounding', 'true'); - expect(spy).not.nthCalledWith(7); + expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true'); + expect(spy).not.nthCalledWith(6); }); describe('`isDevEnv`', () => { diff --git a/src/app/chrome-flags.ts b/src/app/chrome-flags.ts index 12639d3d..efbf21ad 100644 --- a/src/app/chrome-flags.ts +++ b/src/app/chrome-flags.ts @@ -26,7 +26,6 @@ export const setChromeFlags = () => { 'disable-gpu': flagsConfig.disableGpu || null, 'disable-gpu-compositing': flagsConfig.disableGpu || null, 'enable-experimental-web-platform-features': 'true', - 'enable-features': 'NetworkService,NetworkServiceInProcess', }; if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) { configFlags['disable-renderer-backgrounding'] = 'true';