if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2024-12-28 09:51:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

SDA-2091 - Only pass required data via IPC (#1003)

Browse Source
This commit is contained in:
Kiran Niranjan 2020-05-26 14:06:00 +05:30 committed by GitHub
parent d382d46ea1
commit b7bafe932f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/common/api-interface.ts
View File

@ -119,8 +119,9 @@ type Theme = '' | 'light' | 'dark';
export interface INotificationData {
id: number;
title: string;
text: string;
body: string;
image: string;
icon: string;
flash: boolean;
color: string;
tag: string;

3
src/demo/index.html
View File

@ -320,6 +320,9 @@
alert('error=' + event.result);
};
ssfNotificationHandler.addEventListener('error', onerror);
} else if (window.manaSSF) {
const callback = () => { console.log('notification clicked') };
window.manaSSF.showNotification(notf, callback);
} else {
window.postMessage({ method: 'notification', data: notf }, '*');
}

26
src/renderer/notification.ts
View File

@ -192,7 +192,31 @@ class Notification extends NotificationHandler {
notificationWindow.displayTimer = timeoutId;
}
notificationWindow.webContents.send('notification-data', data);
const {
title,
company,
body,
image,
icon,
id,
color,
flash,
isExternal,
theme,
} = data;
notificationWindow.webContents.send('notification-data', {
title,
company,
body,
image,
icon,
id,
color,
flash,
isExternal,
theme,
});
notificationWindow.showInactive();
}