From 2b77c4e6421f9b051c40eb6faafe3654bb62f27a Mon Sep 17 00:00:00 2001
From: Symphony <symphony@Vikass-MacBook-Pro.local>
Date: Sun, 2 Jul 2017 18:23:34 +0530
Subject: [PATCH] 1. Fixed download manager test issues. 2. Removed usage of
 jQuery for tests.

---
 js/windowMgr.js               |  2 +-
 tests/DownloadManager.test.js | 56 ++++++++++++++---------------------
 2 files changed, 24 insertions(+), 34 deletions(-)

diff --git a/js/windowMgr.js b/js/windowMgr.js
index 5c938cd2..decba734 100644
--- a/js/windowMgr.js
+++ b/js/windowMgr.js
@@ -195,7 +195,7 @@ function doCreateMainWindow(initialUrl, initialBounds) {
         webContents.send('downloadProgress');
 
         // Send file path when download is complete
-        item.once('done', (event, state) => {
+        item.once('done', (e, state) => {
             if (state === 'completed') {
                 let data = {
                     _id: getGuid(),
diff --git a/tests/DownloadManager.test.js b/tests/DownloadManager.test.js
index c8120193..20e8b7f5 100644
--- a/tests/DownloadManager.test.js
+++ b/tests/DownloadManager.test.js
@@ -1,73 +1,59 @@
 const downloadManager = require('../js/downloadManager/downloadManager');
 const electron = require('./__mocks__/electron');
-const $ = require('jquery');
-
-describe('download manager', function() {
 
+describe('download manager', function () {
     describe('Download Manager to create DOM once download is initiated', function () {
-
         beforeEach(function () {
             global.document.body.innerHTML =
                 '<div id="download-main">' +
                 '</div>';
         });
 
-        it('should inject download bar element into DOM once download is initiated', function() {
-
-            electron.ipcRenderer.send('downloadCompleted', {_id: '12345', fileName: 'test', total: 100});
-
+        it('should inject download bar element into DOM once download is initiated', function () {
+            electron.ipcRenderer.send('downloadCompleted', { _id: '12345', fileName: 'test', total: 100 });
             expect(document.getElementsByClassName('text-cutoff')[0].innerHTML).toBe('test');
             expect(document.getElementById('per').innerHTML).toBe('100 Downloaded');
-
         });
 
-        it('should inject multiple download items during multiple downloads', function() {
-
-            electron.ipcRenderer.send('downloadCompleted', {_id: '12345', fileName: 'test', total: 100});
-            electron.ipcRenderer.send('downloadCompleted', {_id: '67890', fileName: 'test1', total: 200});
+        it('should inject multiple download items during multiple downloads', function () {
+            electron.ipcRenderer.send('downloadCompleted', { _id: '12345', fileName: 'test', total: 100 });
+            electron.ipcRenderer.send('downloadCompleted', { _id: '67890', fileName: 'test1', total: 200 });
 
             let fileNames = document.getElementsByClassName('text-cutoff');
-
             expect(fileNames[0].innerHTML).toBe('test1');
             expect(fileNames[1].innerHTML).toBe('test');
             expect(document.getElementById('per').innerHTML).toBe('100 Downloaded');
 
             let downloadElements = document.getElementsByClassName('download-element');
-
             expect(downloadElements[0].id).toBe('67890');
             expect(downloadElements[1].id).toBe('12345');
-
         });
 
     });
 
     describe('Download Manager to initiate footer', function () {
-
         beforeEach(function () {
             global.document.body.innerHTML =
-                '<div id="download-manager-footer" class="hidden">' +
-                    '<div id="download-main">' +
+                '<div id="footer" class="hidden">' +
+                    '<div id="download-manager-footer">' +
+                        '<div id="download-main">' +
+                        '</div>' +
                     '</div>' +
                 '</div>';
         });
 
-        it('should inject dom element once download is completed', function() {
-
+        it('should inject dom element once download is completed', function () {
             electron.ipcRenderer.send('downloadProgress');
-
-            expect(document.getElementById('download-manager-footer').classList).not.toContain('hidden');
-
+            expect(document.getElementById('footer').classList).not.toContain('hidden');
         });
 
-        it('should remove the download bar and clear up the download items', function() {
+        it('should remove the download bar and clear up the download items', function () {
 
             electron.ipcRenderer.send('downloadProgress');
+            expect(document.getElementById('footer').classList).not.toContain('hidden');
 
-            console.log(document.getElementById('download-manager-footer').classList);
-            expect(document.getElementById('download-manager-footer').classList).not.toContain('hidden');
-
-            $('#close-download-bar').click();
-            expect(document.getElementById('download-manager-footer').classList).toContain('hidden');
+            document.getElementById('close-download-bar').click();
+            expect(document.getElementById('footer').classList).toContain('hidden');
 
         });
 
@@ -77,16 +63,20 @@ describe('download manager', function() {
 
         beforeEach(function () {
             global.document.body.innerHTML =
-                '<div id="download-manager-footer" class="hidden">' +
+                '<div id="footer" class="hidden">' +
+                    '<div id="download-manager-footer">' +
+                        '<div id="download-main">' +
+                        '</div>' +
+                    '</div>' +
                 '</div>';
         });
 
-        it('should inject ul element if not found', function() {
+        it('should inject ul element if not found', function () {
 
             electron.ipcRenderer.send('downloadProgress');
 
             expect(document.getElementById('download-main')).not.toBeNull();
-            expect(document.getElementById('download-manager-footer').classList).not.toContain('hidden');
+            expect(document.getElementById('footer').classList).not.toContain('hidden');
 
         });