From c9c38605c51f002161d27e1691ad903dba1d59c2 Mon Sep 17 00:00:00 2001 From: Vishwas Shashidhar Date: Wed, 13 Feb 2019 18:16:27 +0530 Subject: [PATCH] ELECTRON-1070: let electron handle protocol registration (#568) * ELECTRON-1070: add default protocol client code for windows * ELECTRON-1070: add comments * bump up version number --- js/main.js | 9 ++++----- package.json | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/js/main.js b/js/main.js index b3567cfb..001adbe1 100644 --- a/js/main.js +++ b/js/main.js @@ -49,6 +49,10 @@ require('./mainApiMgr.js'); // monitor memory of main process require('./memoryMonitor.js'); +// adds 'symphony' as a protocol in the system. +// plist file in macOS and registry entries on windows +app.setAsDefaultProtocolClient('symphony'); + const windowMgr = require('./windowMgr.js'); const { ContextMenuBuilder } = require('electron-spellchecker'); const i18n = require('./translation/i18n'); @@ -225,12 +229,7 @@ app.on('activate', function () { } }); -// adds 'symphony' as a protocol in the system. plist file in macOS - -// on windows, we create the protocol handler via the installer -// because electron leaves registry traces upon uninstallation if (isMac) { - app.setAsDefaultProtocolClient('symphony'); // Sets application version info that will be displayed in about app panel app.setAboutPanelOptions({ applicationVersion: `${clientVersion}-${version}`, version: buildNumber }); } diff --git a/package.json b/package.json index a93196c7..830eb080 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "Symphony", "productName": "Symphony", - "version": "4.4.1", + "version": "4.4.2", "clientVersion": "1.54", "buildNumber": "0", "description": "Symphony desktop app (Foundation ODP)",