Merge branch 'master' into electron_9.1.1

This commit is contained in:
Johan Kwarnmark 2020-07-29 11:04:59 +02:00 committed by GitHub
commit d1792fc671
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 36 additions and 41 deletions

View File

@ -2,7 +2,7 @@
addReviewers: true
# Set to true to add assignees to pull requests
addAssignees: true
addAssignees: author
# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:

32
.github/config.yml vendored
View File

@ -1,32 +0,0 @@
# Configuration for welcome - https://github.com/behaviorbot/welcome
# Configuration for new-issue-welcome - https://github.com/behaviorbot/new-issue-welcome
# Comment to be posted to on first time issues
newIssueWelcomeComment: >
Thanks for opening your first issue here! Be sure to follow the issue template!
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome
# Comment to be posted to on PRs from first time contributors in your repository
newPRWelcomeComment: >
Thanks for opening this pull request! Please check out our contributing guidelines.
# Configuration for first-pr-merge - https://github.com/behaviorbot/first-pr-merge
# Comment to be posted to on pull requests merged by a first time user
firstPRMergeComment: >
Congrats on merging your first pull request! We here at Symphony are proud of you!
# It is recommended to include as many gifs and emojis as possible!
## Trop (Backporting PRs) Configuration
watchedProject:
name: SymphonyElectron
# Users authorized to run manual trop backports
authorizedUsers:
- VishwasShashidhar
- KiranNiranjan
- johankwarnmarksymphony
- mattias-symphony

18
.github/semantic.yml vendored Normal file
View File

@ -0,0 +1,18 @@
# Always validate the PR title, and ignore the commits
titleOnly: true
# By default types specified in commitizen/conventional-commit-types is used.
# See: https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json
# You can override the valid types
types:
- feat
- fix
- docs
- style
- refactor
- perf
- test
- build
- ci
- chore
- revert

8
.github/workflows/action.yml vendored Normal file
View File

@ -0,0 +1,8 @@
name: 'Auto Assign'
on: pull_request
jobs:
add-reviews:
runs-on: ubuntu-latest
steps:
- uses: kentaro-m/auto-assign-action@v1.1.1

View File

@ -98,8 +98,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(5);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
it('should set `disable-renderer-backgrounding` chrome flag correctly when cloud config PMP setting is ENABLED', () => {
@ -110,8 +110,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(7, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(8);
expect(spy).nthCalledWith(8, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(9);
});
it('should set `disable-renderer-backgrounding` chrome flag when any one is ENABLED ', () => {
@ -132,8 +132,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(5);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
it('should set `disable-renderer-backgrounding` chrome flag when PMP is ENABLED', () => {
@ -154,8 +154,8 @@ describe('chrome flags', () => {
});
const spy = jest.spyOn(app.commandLine, 'appendSwitch');
setChromeFlags();
expect(spy).nthCalledWith(4, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(5);
expect(spy).nthCalledWith(5, 'disable-renderer-backgrounding', 'true');
expect(spy).not.nthCalledWith(6);
});
describe('`isDevEnv`', () => {

View File

@ -25,6 +25,7 @@ export const setChromeFlags = () => {
'disable-d3d11': flagsConfig.disableGpu || null,
'disable-gpu': flagsConfig.disableGpu || null,
'disable-gpu-compositing': flagsConfig.disableGpu || null,
'enable-experimental-web-platform-features': 'true',
};
if (flagsConfig.customFlags.disableThrottling === CloudConfigDataTypes.ENABLED || disableThrottling === CloudConfigDataTypes.ENABLED) {
configFlags['disable-renderer-backgrounding'] = 'true';