Merge pull request #971 from johankwarnmarksymphony/sda-1956

fix: SDA-1956: RTC: Missing red border when screen sharing whole screen
This commit is contained in:
Johan Kwarnmark 2020-04-14 16:14:51 +02:00 committed by GitHub
commit d2e7bd2345
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -639,6 +639,13 @@ export class WindowHandler {
} else if (isMac && type === 'screen') { } else if (isMac && type === 'screen') {
const dispId = source.id.split(':')[1]; const dispId = source.id.split(':')[1];
this.execCmd(this.screenShareIndicatorFrameUtil, [ dispId ]); this.execCmd(this.screenShareIndicatorFrameUtil, [ dispId ]);
} else if (isWindowsOS && type === 'screen') {
logger.info('window-handler: source.display_id: ' + source.display_id);
if (source.display_id !== '') {
this.execCmd(this.screenShareIndicatorFrameUtil, [ source.display_id ]);
} else {
this.execCmd(this.screenShareIndicatorFrameUtil, [ '0' ]);
}
} }
} }
} }
@ -828,23 +835,22 @@ export class WindowHandler {
}); });
} }
logger.info('window-handler: createScreenSharingIndicatorWindow, displayId: ' + displayId);
if (displayId !== '') { if (displayId !== '') {
const displays = electron.screen.getAllDisplays(); if (isLinux) {
const displays = electron.screen.getAllDisplays();
displays.forEach((element) => { displays.forEach((element) => {
if (displayId === element.id.toString()) { logger.info('window-handler: element.id.toString(): ' + element.id.toString());
logger.info(`window-handler: element:`, element); if (displayId === element.id.toString()) {
if (isWindowsOS) { logger.info(`window-handler: element:`, element);
this.execCmd(this.screenShareIndicatorFrameUtil, [ displayId ]); this.createScreenSharingFrameWindow('screen-sharing-frame',
} else if (isLinux) { element.workArea.width,
this.createScreenSharingFrameWindow('screen-sharing-frame', element.workArea.height,
element.workArea.width, element.workArea.x,
element.workArea.height, element.workArea.y);
element.workArea.x,
element.workArea.y);
} }
} });
}); }
} }
this.screenSharingIndicatorWindow = createComponentWindow('screen-sharing-indicator', opts); this.screenSharingIndicatorWindow = createComponentWindow('screen-sharing-indicator', opts);