if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2024-12-28 09:51:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

electron-135: fixes the raised issue

Browse Source
This commit is contained in:
Vishwas Shashidhar 2017-10-06 15:58:26 +05:30
parent b264331a54
commit d3706d6b6d
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
js/windowMgr.js
View File

@ -250,17 +250,7 @@ function doCreateMainWindow(initialUrl, initialBounds) {
webContents.send('downloadCompleted', data);
}
});
});
// bug in electron is preventing this from working in sandboxed evt...
// https://github.com/electron/electron/issues/8841
mainWindow.webContents.on('will-navigate', function(event, willNavUrl) {
if (!sandboxed) {
return;
}
event.preventDefault();
openUrlInDefaultBrower(willNavUrl);
});
});
// open external links in default browser - a tag with href='_blank' or window.open
mainWindow.webContents.on('new-window', function (event, newWinUrl,
@ -365,6 +355,11 @@ function doCreateMainWindow(initialUrl, initialBounds) {
});
});
browserWin.webContents.on('new-window', (childEvent, childWinUrl) => {
childEvent.preventDefault();
openUrlInDefaultBrower(childWinUrl);
});
addWindowKey(newWinKey, browserWin);
// Method that sends bound changes as soon
@ -381,7 +376,7 @@ function doCreateMainWindow(initialUrl, initialBounds) {
});
} else {
event.preventDefault();
openUrlInDefaultBrower(newWinUrl)
openUrlInDefaultBrower(newWinUrl);
}
});
@ -524,7 +519,7 @@ function sendChildWinBoundsChange(window) {
* @param urlToOpen
*/
function openUrlInDefaultBrower(urlToOpen) {
if (urlToOpen) {
if (urlToOpen) {
electron.shell.openExternal(urlToOpen);
}
}