if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Electron-325 (Removed restriction from opening a popup from another popup window) (#318)

Browse Source 
- Updated the event `new-window` by removing the restriction to open new windows in pop-outs
- Added Spectron test cases for pop-outs
- Fix PR concerns
This commit is contained in:
Kiran Niranjan
2018-03-15 17:18:06 +05:30
committed by Vishwas Shashidhar
parent 944eb389ba
commit dc7079e0d7
4 changed files with 156 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
demo/win.html
View File

@@ -1,5 +1,7 @@
<html>
<head>
<meta charset="UTF-8">
<title>Test pop-out window</title>
</head>
Test Window has been opened
<p>
@@ -7,6 +9,16 @@ Test Window has been opened
<input type='text' id='tag' value=''/>
</p>
<button id="open-win">Open a new child window</button>
<br>
<br>
<button id="open-in-browser">Open Symphony in browser</button>
<br>
<br>
<a href="https://symphony.com" target="_blank">Open Symphony</a>
<hr>
<p>Badge Count:<p>
<button id='inc-badge'>increment badge count</button>
@@ -20,5 +32,16 @@ Test Window has been opened
badgeCount++;
ssf.setBadgeCount(badgeCount);
});
var openWinButton = document.getElementById('open-win');
openWinButton.addEventListener('click', function() {
win = window.open('childWin.html?x=200&y=200', 'childWin', 'height=500,width=500');
});
var openInBrowser = document.getElementById('open-in-browser');
openInBrowser.addEventListener('click', function () {
window.open('https://symphony.com');
});
</script>
</html>