if/SymphonyElectron
1
0
Fork 0
mirror of https://github.com/finos/SymphonyElectron.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1903 from NguyenTranHoangSym/SDA-4182_racing

Browse Source 
SDA-4182_racing: Add racing condition
This commit is contained in:
NguyenTranHoangSym 2023-07-20 15:47:34 +07:00 committed by GitHub
commit f8ac374c54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/app/registry-handler.ts
View File

@ -12,24 +12,22 @@ export const retrieveWindowsRegistry = async (): Promise<string> => {
const Registry = require('winreg'); const Registry = require('winreg');
const registryLocalStore = RegistryStore; const registryLocalStore = RegistryStore;
const fetchLogic = (err, channel) => { const fetchLogic = (err, channel) => {
if (err) { if (err || !channel) {
logger.info('registry-handler: error occurred. Details: ', err); logger.error('registry-handler: error occurred. Details: ', err);
return 'An error has occurred'; return '';
} else { } else {
if (channel.type === RegistryValueType.REG_SZ) { if (channel?.type === RegistryValueType.REG_SZ) {
registryLocalStore.setRegistry({ currentChannel: channel.value }); registryLocalStore.setRegistry({ currentChannel: channel.value });
logger.info( logger.info(
'registry-handler: value retrieved successfully, send to Registry Store', 'registry-handler: value retrieved successfully, send to Registry Store',
); );
return channel.value; return channel.value;
} else { } else {
logger.info( logger.info(
'registry-handler: the value was looked for did not exist or its VALUE_TYPE is incorrect', 'registry-handler: the value was looked for did not exist or its VALUE_TYPE is incorrect',
); );
return '';
return 'Key Value doesnt exist';
} }
} }
}; };
@ -44,18 +42,21 @@ export const retrieveWindowsRegistry = async (): Promise<string> => {
key: CHANNEL_NEST_LOCATION, key: CHANNEL_NEST_LOCATION,
}); });
return regKeyUser.get(CHANNEL_KEY, (error, channel) => { return new Promise((resolve) => {
if (error && !channel) { regKeyUser.get(CHANNEL_KEY, (error, channel) => {
regKeyLocal.get(CHANNEL_KEY, (err, localChannel) => { if (error || !channel) {
return fetchLogic(err, localChannel); logger.error('registry-handler: error occurred. Details: ', error);
});
} else if (channel.type === RegistryValueType.REG_SZ) {
registryLocalStore.setRegistry({ currentChannel: channel.value });
logger.info(
'registry-handler: value retrieved successfully, send to Registry Store',
);
return channel; regKeyLocal.get(CHANNEL_KEY, (err, localChannel) => {
} resolve(fetchLogic(err, localChannel));
});
} else if (channel.type === RegistryValueType.REG_SZ) {
logger.info(
'registry-handler: value retrieved successfully, send to Registry Store',
);
registryLocalStore.setRegistry({ currentChannel: channel.value });
resolve(channel.value);
}
});
}); });
}; };