From f9baa9d453da1bc0e3a21ff9a1e0e395925fdb9f Mon Sep 17 00:00:00 2001
From: Kiran Niranjan <kiran.niranjan@symphony.com>
Date: Mon, 4 Nov 2024 17:16:47 +0530
Subject: [PATCH] SDA-4717 - Bump version 25.1.0 (#2217)

* SDA-4717 Bump SDA and electron version

* SDA-4717 Update event
---
 package-lock.json            | 12 ++++++------
 package.json                 |  4 ++--
 src/app/window-handler.ts    |  4 ----
 src/renderer/notification.ts |  2 +-
 4 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 93b1f4e4..4624b12e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "symphony",
-  "version": "24.11.0",
+  "version": "25.1.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "symphony",
-      "version": "24.11.0",
+      "version": "25.1.0",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
@@ -40,7 +40,7 @@
         "cheerio": "v1.0.0-rc.12",
         "cross-env": "7.0.3",
         "del": "3.0.0",
-        "electron": "32.0.1",
+        "electron": "33.0.2",
         "electron-builder": "^24.13.2",
         "electron-devtools-installer": "^3.2.0",
         "electron-icon-maker": "0.0.5",
@@ -6310,9 +6310,9 @@
       }
     },
     "node_modules/electron": {
-      "version": "32.0.1",
-      "resolved": "https://repo.symphony.com/artifactory/api/npm/npm-virtual-dev/electron/-/electron-32.0.1.tgz",
-      "integrity": "sha512-5Hd5Jaf9niYVR2hZxoRd3gOrcxPOxQV1XPV5WaoSfT9jLJHFadhlKtuSDIk3U6rQZke+aC7GqPPAv55nWFCMsA==",
+      "version": "33.0.2",
+      "resolved": "https://repo.symphony.com/artifactory/api/npm/npm-virtual-dev/electron/-/electron-33.0.2.tgz",
+      "integrity": "sha512-C2WksfP0COsMHbYXSJG68j6S3TjuGDrw/YT42B526yXalIlNQZ2GeAYKryg6AEMkIp3p8TUfDRD0+HyiyCt/nw==",
       "dev": true,
       "hasInstallScript": true,
       "dependencies": {
diff --git a/package.json b/package.json
index c6110b34..66839beb 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "symphony",
   "productName": "Symphony",
-  "version": "24.12.0",
+  "version": "25.1.0",
   "clientVersion": "2.0.1",
   "buildNumber": "0",
   "searchAPIVersion": "1.55.3",
@@ -181,7 +181,7 @@
     "cheerio": "v1.0.0-rc.12",
     "cross-env": "7.0.3",
     "del": "3.0.0",
-    "electron": "32.1.2",
+    "electron": "33.0.2",
     "electron-builder": "^24.13.2",
     "electron-devtools-installer": "^3.2.0",
     "electron-icon-maker": "0.0.5",
diff --git a/src/app/window-handler.ts b/src/app/window-handler.ts
index fcf81651..49b64e88 100644
--- a/src/app/window-handler.ts
+++ b/src/app/window-handler.ts
@@ -559,10 +559,6 @@ export class WindowHandler {
       });
     });
 
-    this.mainWindow.once('ready-to-show', (event: Event) => {
-      logger.info(`window-handler: Main Window ready to show: ${event}`);
-    });
-
     this.mainWebContents.on(
       'did-fail-load',
       (_, errorCode: number, errorDescription: string) => {
diff --git a/src/renderer/notification.ts b/src/renderer/notification.ts
index e94cc65c..5dcb3d7c 100644
--- a/src/renderer/notification.ts
+++ b/src/renderer/notification.ts
@@ -220,7 +220,7 @@ class Notification extends NotificationHandler {
 
     // This is a workaround to fix an issue with electron framework
     // https://github.com/electron/electron/issues/611
-    notificationWindow.on('resize', (event) => {
+    notificationWindow.on('will-resize', (event) => {
       event.preventDefault();
     });